Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I am currently refactoring this module for different reasons on https://github.com/derhasi/cleverreach :
- Make block configuration exportable
- Use Entity API for common tasks
- Refactor and simplify some functions (e.g. store groups in cache as they are not really used for anything else)
- Adding form weight to fields
- Maybe implementing Double Opt In
- Maybe implementing archives
Feel free to share your thoughts, comment or review on github or here ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | interdiff.txt | 2.12 KB | derhasi |
| #4 | refactoring-2445177-4.patch | 65.21 KB | derhasi |
Comments
Comment #1
kasalla CreditAttribution: kasalla commentedI'm actually working on this project. I will implement the Double Opt In feature in the next version (in 1-2 days). If you have some features for this module, please create a .patch and i will add them into the next dev version.
Comment #2
derhasi CreditAttribution: derhasi commentedThat's great. I will do some cleanup tomorrow. As implementing Entity API export lead to a lot of rewriting, a patch would be very big. Currently I did not cut any functionality, so it covers the use cases of 1.x. I'm not sure if you want such a "big" rewrite of your module.
Based on your opinion I would provide a single or multiple patches. The github repo currently only is there for pushing the development somewhere for our composer based workflow and for giving you the opportunity to easily review the changes.
You can see the comparison to the 1.x in https://github.com/derhasi/cleverreach/compare/7.x-2.x. Currently both UIs are still active, but after the cleanup tomorrow the picture should be a little more clearer.
Comment #3
derhasi CreditAttribution: derhasi commentedSo I did some cleanup and provided an update path for the new Entity API Storage: See the patch attached or the github comparison.
Currently I named the upate hooks for a 7.1 release. If you want to put that in the 7.2 release branch, I'd need to rename those again. The patch does a lot of reworking, but most of it is backwards compatible, except the renaming of the theme function and the form callback.
I would keep on implementing #2135241: Implement double opt-in and #2353425: Custom label for fields/attributes based on this refactoring, as I need that for our project right now. Please let me know if you have any restrictions on that. I'm around in IRC too ;)
Comment #4
derhasi CreditAttribution: derhasi commentedI updated the branch name on github, so the compare view moved to https://github.com/derhasi/cleverreach/compare/2445177-refactoring.
In addition I had to do some minor changes due to newline and a wrong label (see interdiff.txt).
Comment #6
derhasi CreditAttribution: derhasi commentedMerged to dev with help of Joel/kasalla.