I've got another round of fixes coming in. Keeping note of what I need to change here.

_password_strength_form_helper() should be renamed to something more meaningful like _password_strength_form_calculate_strength()

CommentFileSizeAuthor
#2 2445079-cleanup-2.patch2.7 KBbanviktor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

@scor anything else? And are you able to work on this or should I do it? You've provided 90% of the work - happy to finish it off if you like.

banviktor’s picture

Status: Active » Needs review
FileSize
2.7 KB

This is my take on the issue, though I'm not sure what "Pass user account properties into checker." refers to on line 379. Looks like there was some code under it but got deleted. Or simply means returning the data?

greggles’s picture

Status: Needs review » Fixed

This was committed. Not sure anything else needs to be done, but I think a new ticket can be opened for those if/when they are found.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.