pass by reference breaks parser [#2444753]

It looks like theme hooks that already pass in $variables by reference break the parser.

Theme hooks output by Twigify are always passed by reference, but it looks like it makes the assumption they were not passed by reference to begin with, and so doesn't check for that.

The result is that the new function's signature has an unnamed variable: "&$"

:-/

Comments

Comment #1

forestmars CreditAttribution: forestmars commented 3 March 2015 at 05:41

Status:

Active

» Needs review

This is working now and committed to the 7.x-1.1 branch.

I had to use the concrete value for T_REFERENCE instead of the constant, so that could be cleaned up later. (Should always use constants, not concrete values.)