[D7] Taxonomy delete link

The git command fails with a 404 error.

You need to post the the public git clone command for your sandbox project. On your sandbox page select the 'version control' tab, then deselect 'maintainer', then click on the 'show' button, then copy and paste the git clone command.

The module works as advertised, as far as I can see. I did not test it with views.

Yes

Yes

Yes

Yes

Yes

This file is woefully incomplete. You should read and comply
with the recommendations here:
https://www.drupal.org/node/2181737

Yes

Yes

Passes on a standard Coder review, but does not pass under a 'critical' review.
Report follows.

taxonomy_delete_link.module

Line 6: Docblock should be immediately above taxonomy_delete_link_menu (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_menu() {

severity: minorreview: comment_comment_docblock_missingLine 24: Docblock should be immediately above taxonomy_delete_link_admin_paths (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_admin_paths() {

severity: minorreview: comment_comment_docblock_missingLine 34: Docblock should be immediately above taxonomy_delete_link_term_delete_access (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_term_delete_access($term) {

severity: minorreview: comment_comment_indentLine 39: indent secondary line of comment one space [comment_comment_indent]

* Implements hook_form_FORM_ID_alter().

severity: minorreview: comment_comment_implementsLine 39: Format should be * Implements hook_foo(). [comment_comment_implements]

* Implements hook_form_FORM_ID_alter().

severity: minorreview: comment_comment_indentLine 40: indent secondary line of comment one space [comment_comment_indent]

*/

severity: minorreview: comment_comment_docblock_missingLine 41: Docblock should be immediately above taxonomy_delete_link_form_taxonomy_overview_terms_alter (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_form_taxonomy_overview_terms_alter(&$form, &$form_state, $form_id) {

severity: minorreview: comment_comment_indentLine 46: indent secondary line of comment one space [comment_comment_indent]

* Implements hook_theme().

severity: minorreview: comment_comment_implementsLine 46: Format should be * Implements hook_foo(). [comment_comment_implements]

* Implements hook_theme().

severity: minorreview: comment_comment_indentLine 47: indent secondary line of comment one space [comment_comment_indent]

*/

severity: minorreview: comment_comment_docblock_missingLine 48: Docblock should be immediately above taxonomy_delete_link_theme (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_theme() {

severity: minorreview: comment_comment_indentLine 58: indent secondary line of comment one space [comment_comment_indent]

*/

severity: minorreview: comment_comment_docblock_missingLine 59: Docblock should be immediately above theme_taxonomy_delete_link_taxonomy_overview_terms (Drupal Docs) [comment_comment_docblock_missing]

function theme_taxonomy_delete_link_taxonomy_overview_terms($variables) {

taxonomy_delete_link.admin.inc

Line 6: Docblock should be immediately above taxonomy_delete_link_confirm_delete (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_confirm_delete($form, &$form_state, $term) {

severity: minorreview: comment_comment_docblock_missingLine 33: Docblock should be immediately above taxonomy_delete_link_confirm_delete_submit (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_confirm_delete_submit($form, &$form_state) {

taxonomy_delete_link_views.views.inc

Line 3: indent secondary line of comment one space [comment_comment_indent]

* @file

severity: minorreview: comment_comment_indentLine 4: indent secondary line of comment one space [comment_comment_indent]

* Implements hook_views_data().

severity: minorreview: comment_comment_implementsLine 4: Format should be * Implements hook_foo(). [comment_comment_implements]

* Implements hook_views_data().

severity: minorreview: comment_comment_indentLine 5: indent secondary line of comment one space [comment_comment_indent]

*/

severity: minorreview: comment_comment_docblock_missingLine 6: Docblock should be immediately above taxonomy_delete_link_views_views_data (Drupal Docs) [comment_comment_docblock_missing]

function taxonomy_delete_link_views_views_data() {

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbalis_m2443851git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

The review I ran is the 'critical' one, meaning it's as picky as possible. It definitely passed. If you can't fix an item because of the limits imposed by another module -- the post popular one in the Drupal universe -- just leave it as it is -- that's my opinion.

I just reviewed the module and tested it in multiple sites, some with large taxonomies. As far as I can see it works fine and is coded well too. I think its ready for RTBC.

i tried to install it on Drupal 7.32 and 7.34. Its working properly on both versions.
On Parereview:

Review of the 7.x-1.x branch (commit 2baba0c):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...iews/includes/taxonomy_delete_link_views_handler_delete_term_link.inc
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
29 | ERROR | Public method name
| | "TaxonomyDeleteLinkViewsHandlerDeleteTermLink::option_definition"
| | is not in lowerCamel format
40 | ERROR | Public method name
| | "TaxonomyDeleteLinkViewsHandlerDeleteTermLink::options_form"
| | is not in lowerCamel format
---------------------------------------------------------------------------

Please make sure to address this 2 issues.

@blias_m - does this mean you are stuck on this?

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. Yes, seems false issues.

Review of the 7.x-1.x branch (commit 2baba0c):

FILE: ...iews/includes/taxonomy_delete_link_views_handler_delete_term_link.inc
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
29 | ERROR | Public method name
| | "TaxonomyDeleteLinkViewsHandlerDeleteTermLink::option_definition"
| | is not in lowerCamel format
40 | ERROR | Public method name
| | "TaxonomyDeleteLinkViewsHandlerDeleteTermLink::options_form"
| | is not in lowerCamel format
---------------------------------------------------------------------------

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follow the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. A hook_help() would be nice.
2. Project Page: Extend this little bit more, better to go through Tips for a great project page again.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Additions of views feature and Docs/comments looks good to me. I tested the module functionality and it worked as intended.

Removing review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

Assigning to @mpdonadio for a second look if he has time.

Before I review this, I just want to mention that the output of PAReview.sh should never be the sole reason to push an application back to needs review. Perfect adherence to Drupal Coding Standards is the goal, but not a hard requirement. And, as we are seeing here, is impossible to obtain with the way Views and cTools needs things named.

• Delete link on taxonomy overview page works as expected
• Views field handler provided by the sub module also works well
• Menu access callback is working correctly
• pareview.sh passes (ignoring the view method name errors as these cannot be fixed by this module)

Automated Review

Review of the 7.x-1.x branch (commit 2baba0c):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: .../mattd/Documents/Drupal/PAR/pareview_temp/taxonomy_delete_link.module
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
 171 | ERROR | [x] Closing parenthesis of array declaration must be on a
     |       |     new line
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: ...iews/includes/taxonomy_delete_link_views_handler_delete_term_link.inc
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
 29 | ERROR | Public method name
    |       | "TaxonomyDeleteLinkViewsHandlerDeleteTermLink::option_definition"
    |       | is not in lowerCamel format
 40 | ERROR | Public method name
    |       | "TaxonomyDeleteLinkViewsHandlerDeleteTermLink::options_form"
    |       | is not in lowerCamel format
---------------------------------------------------------------------------

Time: 276ms; Memory: 7Mb

Manual Review

Secure code

Looks OK to me. Tried a few explicit XSS w/o luck.

Coding style & Drupal API usage

taxonomy_delete_link_form_taxonomy_overview_terms_alter() doesn't need the third parameter since you are using the hook_form_FORM_ID_alter version.

Personally, I don't think the views integration needs to be a separate module.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thanks for your contribution, balis_m!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.