Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
TypedDataTrait wraps methods for "I hold a reference to a TypedData*Manager* object".
--> by common standards, it should rather be named TypedDataManagerAwareTrait.
See Symfony's ContainerAwareTrait, or PSR-3's LoggerAwareTrait
Comment | File | Size | Author |
---|---|---|---|
#13 | 2443733-TypedDataTrait-13.patch | 1.35 KB | yched |
#12 | 2443733-TypedDataTrait-12.patch | 3.83 KB | yched |
#8 | interdiff.txt | 1.4 KB | yched |
#7 | 2443733-TypedDataTrait-7.patch | 4.66 KB | yched |
#4 | 2443733-TypedDataTrait-4.patch | 3.25 KB | yched |
Comments
Comment #1
yched CreditAttribution: yched commentedComment #2
yched CreditAttribution: yched commentedComment #4
yched CreditAttribution: yched commentedOops, messed up my git commands somehow, patch missed the actual rename...
Comment #5
fagoAgreed, patch looks good also. However, that's an API change for possibly existing users of that trait? Should we re-add the existing trait for BC (extending the new one) and mark it as deprecated?
Comment #6
klausiThe deprecation sounds like a good idea to prevent an API change.
Comment #7
yched CreditAttribution: yched commentedwe can do that
Comment #8
yched CreditAttribution: yched commentedManual interdiff
Comment #9
yched CreditAttribution: yched commentedbump ? :-)
Comment #10
klausiYep, looks good.
Comment #12
yched CreditAttribution: yched commentedStraight reroll
Comment #13
yched CreditAttribution: yched commentedOops, forgot to "git add" the new file after manually applying.
Comment #15
xjmThis issue is a task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary?
Also, #13 looks like an incomplete patch?