Drupal core uses integer value, and in the menu_links table the hidden value is an integer value

however in entity_translation_i18n_menu.module a boolean is used instead of an integer value.

In some cases this can cause a "PDO expects integer, boolean given/error warning" that may occur depending on flavour of server stack used.

it is far safer to use the integer value as is the standard.

See attached patch

CommentFileSizeAuthor
#3 entity_translation_i18n_menu_integer_not_bool-2442953-3.patch684 bytesjoseph.olstad
#1 entity_translation_i18n_menu_integer_not_bool-2442953.1.patch738 bytesjoseph.olstad
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
FileSize
entity_translation_i18n_menu_integer_not_bool-2442953.1.patch738 bytes
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
FileSize
entity_translation_i18n_menu_integer_not_bool-2442953-3.patch684 bytes

remove comment as it is already pretty obvious

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Reviewed & tested by the community » Active

I am reviewing this right now

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Active » Closed (won't fix)

Closing this issue as the real solution for our use case was in this issue:

http://drupal.org/project/node/214137 found in patch 17 to wetkit_deployment_source.module

Hope this helps someone down the road.

Although I must say the patch in this issue #2442953 is compatible with what the solution I found was. Probably wouldn't hurt to commit into i18n however our use case did not require a patch to entity_translation (it worked with or without).