[D7] Smiley Emoji

The Smiley Emoji project makes the Emoji from Github available to the Smiley module 7.x-2.x.

Links

https://www.drupal.org/sandbox/mparker17/2078481

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/mparker17/2078481.git smiley_emoji

http://pareview.sh/pareview/httpgitdrupalorgsandboxmparker172078481git

Smooth Review: Quick tips checklist

• Application checklist: completed
• Review bonus: #1, #2, #3.
• Intended Drupal version: D7
• Avoid 3rd party code or images: Smiley Emoji uses the Libraries API to ensure all dependencies are not in the module.
• Similar modules:
  • Textcomplete provides auto-completion for emoji, but does so by replacing the token with an image tag when the text is entered. This means you need permission to access a text format that allows <img> tags (which most site builders forbid for anonymous commenters), and it changes the data saved to the node, making the node dependant on the version of the Textcomplete library installed, and it's location (and, newer versions of the Textcomplete library don't include the emoji).
    The Smiley module does not affect the text saved in the node: instead it performs the replacement using an input filter, meaning the text-to-image replacement happens when the text is rendered. This also removes the dependency on external libraries: if a library changes, the images will work after clearing caches. You can add the Smiley input filter to any text format, regardless of that format's restrictions on allowed tags / HTML (so long as the smiley replacement runs after the allowed-tag filter).
    Smiley Emoji simply registers a list of replacement tokens with the Smiley module.
    A brief read through the code of the Textcomplete module suggests that it would not currently be possible for the Smiley or Smiley Emoji modules to register themselves with Textcomplete to provide smiley previews when text is being entered.
• XSS vulnerabilities: none found.
  This module simply builds an array from file names in the library when asked to by the Smiley module. It filters non-alphanumeric characters from the keys to ensure that even a library with funky file names does not cause problems.
• Translatable: done
• Uninstall variables: no variables used
• Background and experience:
  • mparker17 taught himself Drupal in March 2009 in preparation for a job interview at PeaceWorks Technology Solutions in Waterloo, ON, Canada. He got the job, and worked first as a themer, then a site builder on over 43 Drupal sites before joining Myplanet Digital in Toronto, ON, Canada, where he worked on another 5 enterprise-level Drupal sites, built the Clean Markup module, Reviewed "Migrating to Drupal 7" by Trevor James, Was interviewed on the Modules Unravelled Podcast, episode 079, and attended DrupalCamp Toronto 2012, 2013, DrupalCon Portland 2013, Symfony Live Portland 2013, Palantir.net Drupal 8 Training, and the Drupal Midwest Developer Summit 2013. He later left Myplanet to join OpenConcept Consulting, where he's worked on another 7 Drupal sites, including two for major Canadian organizations, attended DrupalCamp Ottawa 2014, and started volunteering to write the Drupal Core Updates blog series. He's recently was asked to co-ordinate the Drupal Core Update blog series. At time-of-writing, he has 44 commits to Drupal 8 core, and 2 commits to Drupal 7 core. He also occasionally volunteers to maintain Pressflow/7, a friendly, shallow fork of Drupal with integrated performance, scalability, availability, and testing enhancements.
• Automated Project Application Review

Problem/Motivation

I've had a request to promote a project currently in my sandbox, Smiley Emoji, to a full project and make a release.

Proposed resolution

Give mparker17 permission to promote Smiley Emoji to a full project.