Returning FALSE means we can only return errors on one condition, or that callers have to infer what the error is. It also makes callers have to opt in to error checking, and it's way too easy to forget to do that.

Comments

Dave Reid’s picture

Status: Active » Fixed

Fixed in 7.x-3.x now, throws InvalidArgumentException!

  • Dave Reid committed 943bb8e on 7.x-3.x
    Issue #2438109 by Dave Reid: Fixed MpxAccount::load() throws an...
deviantintegral’s picture

:+100:

I think you can get rid of the else clause now.

  • Dave Reid committed 6fabbd2 on 7.x-3.x
    Issue #2438109 by Dave Reid: Simplified return logic in MpxAccount::load...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.