I have noticed a little dependency issue that I would like to lock down.

Resolving issues like this has saved my bacon plenty of times....

the last few lines of dashboard.js

});
};
}
})(jQuery);

but the code makes use of Drupal.settings.dashboard.dashboard

I would like to alter the file prefix to :-

function ($, Drupal, drupalSettings) {

And change the prefix to

}
};
})(jQuery, Drupal, drupalSettings);

or whatever is appropriate.

Comments

markhalliwell’s picture

Status: Active » Closed (won't fix)

I didn't put this JS in there, but my guess is that it's a direct port from core. In which case, we attempt to keep parity between whatever we override/replace whenever possible.

That being said, there is no longer any "dashboard" module in 8.x core. This file will likely be removed eventually.

martin107’s picture

Makes sense - thanks for the prompt reply.