Update 7103, not possible to process update.php [#2437581]

Update 7103, not possible to process update.php:

Failed: PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AS , t.nid AS nid FROM node t WHERE ( IN ('b0558664-c94b-3674-d9df-3e1696b2e4' at line 1: SELECT t. AS , t.nid AS nid FROM
{node}

t WHERE ( IN (:db_condition_placeholder_0, :db_condition_placeholder_1)) ; Array ( [:db_condition_placeholder_0] => b0558664-c94b-3674-d9df-3e1696b2e471 [:db_condition_placeholder_1] => 5e3d8bbe-a1f2-f2d4-fdc0-71e6c23aa837 ) em entity_get_id_by_uuid() (linha 430 de /var/www/sites/all/modules/contrib/uuid/uuid.entity.inc).

Comment	File	Size	Author
#6	uuid-update_7103_conditional-2437581-6.patch	3.32 KB	ron_s
#6	7.x-1.x: PHP 5.4 & MySQL 5.5, D7 17 pass PHP 5.5 & MySQL 5.5, D7 17 pass PHP 5.6 & MySQL 5.5, D7 17 pass PHP 7 & MySQL 5.5, D7 17 pass
#5	uuid-update_7103_conditional-2437581-5.patch	3.32 KB	ron_s
#5	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 14 pass
#1	uuid_update_7103.patch	3.02 KB	vanyamtv
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

vanyamtv CreditAttribution: vanyamtv commented 25 February 2015 at 11:08

File	Size
uuid_update_7103.patch	3.02 KB

Like a quick fix, we can just check if module exists.

Comment #2

vanyamtv CreditAttribution: vanyamtv commented 25 February 2015 at 11:33

Status:

Active

» Needs work

Comment #3

ron_s CreditAttribution: ron_s commented 25 February 2015 at 20:37

Makes sense, although are you saying more work is necessary for this patch, or it needs to be reviewed?

We tested it locally and worked as we would expect. However the formatting of your patch is not correct. It is indented too far and doesn't match Drupal standards.

https://www.drupal.org/coding-standards#indenting

Comment #4

leisurman CreditAttribution: leisurman commented 9 March 2015 at 13:08

I was having errors when i ran update using 7.x-1.0-alpha6. I downgraded to UUID 7.x-1.0-alpha5 and I didn't get the error when running update.

Comment #5

ron_s CreditAttribution: ron_s commented 20 February 2016 at 11:12

Version:	7.x-1.0-alpha6	» 7.x-1.x-dev
Status:	Needs work	» Needs review

File	Size
uuid-update_7103_conditional-2437581-5.patch	3.32 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 14 pass

Here is a clean version of the patch in #1, applied against 7.x-1.x-dev. Please review, thanks.

Comment #6

ron_s CreditAttribution: ron_s commented 8 August 2016 at 06:05

File	Size
uuid-update_7103_conditional-2437581-6.patch	3.32 KB
7.x-1.x: PHP 5.4 & MySQL 5.5, D7 17 pass PHP 5.5 & MySQL 5.5, D7 17 pass PHP 5.6 & MySQL 5.5, D7 17 pass PHP 7 & MySQL 5.5, D7 17 pass

1 file was hidden/shown/deleted

File	Size
uuid-update_7103_conditional-2437581-5.patch	3.32 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 14 pass

Label changes in the latest version of 7.x-1.x-dev has broken the patch. Attached is an updated version.

Can we get this reviewed fairly soon? It's a very simple fix. All it does is add an if (module_exists('uuid')) { conditional to update 7103. Thanks.

Comment #7

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 22 August 2016 at 16:22

Sounds like a duplicate of #2248581: uuid_update_7103() fails.

Comment #8

ron_s CreditAttribution: ron_s commented 2 September 2016 at 10:15

Related issues:

+#2248581: uuid_update_7103() fails

Certainly seems that way. The patches do the same thing... one is an if conditional wrapped around the code, while the other uses a continue. I'm fine with either, module owners just need to decide what they prefer.