Settings is undefined [#2435153]

Problem/Motivation

Not even sure if this is the right module to blame for this, but it happens every once and a while (Couple of days).

A rep keeps noticing it on the batch UI when trying to send a one-time password via views bulk operations. The JS error prevents the ajax from firing and the batch page is blank. Also on the front end very similar "settings not defined" error on a google maps page.

Other modules that may be partly to blame:

memcache storage (clearing memcache resolves the issue temporarily), but that is likely just the storage bin used for advagg (Might move it to the redis storage to see if that helps...)
CDN as you can see the cached pages are.

It could be the bundler too... I've got this on aggressive caching. I've got target bundling at 3 for JS.

Proposed resolution

Remaining tasks

User interface changes

API changes

Comment	File	Size	Author
#4	advagg-2435153-3-fix-missing-json-settings.patch	6.86 KB	mikeytown2
#4
	advagg.png	106.96 KB	joelpittet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mikeytown2 CreditAttribution: mikeytown2 commented 25 February 2015 at 01:02

My guess is the aggressive cache
http://cgit.drupalcode.org/advagg/tree/advagg.module#n1215

Comment #2

joelpittet

English

Vancouver

CreditAttribution: joelpittet commented 25 February 2015 at 01:19

Thank you @mikeytown2 I've changed the bundling to 4, though that may not do anything, I'm just going to try it. But yeah if/when it happens again, I'll change out aggressive cache.

Comment #3

10 March 2015 at 01:41

mikeytown2 committed a9f8173 on 7.x-2.x

Issue #2435153 by mikeytown2: Better json settings handling.

Comment #4

mikeytown2 CreditAttribution: mikeytown2 commented 10 March 2015 at 01:43

Status:

Active

» Fixed

File	Size
advagg-2435153-3-fix-missing-json-settings.patch	6.86 KB

Committed this patch and added a new file called advagg.json.inc; it's has fault tolerant json_decode functionality. Tested different situations with the cache and I think I've fixed some issues that don't appear that often.