Warning: Missing argument 2 for addressfield_default_values(), called in addressfield_tokens.components.inc [#2434707]

We're getting this error lately, on a webform using the address field:

Warning: Missing argument 2 for addressfield_default_values(), called in /home/mysite/public_html/sites/all/modules/addressfield_tokens/addressfield_tokens.components.inc on line 120 and defined in addressfield_default_values() (regel 375 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined variable: instance in addressfield_default_values() (regel 376 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined index: bundles in _addressfield_country_options_list() (regel 874 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Warning: Invalid argument supplied for foreach() in _addressfield_country_options_list() (regel 874 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined variable: instance in addressfield_default_values() (regel 377 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined variable: instance in addressfield_default_values() (regel 404 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Warning: Missing argument 2 for addressfield_default_values(), called in /home/mysite/public_html/sites/all/modules/addressfield_tokens/addressfield_tokens.components.inc on line 120 and defined in addressfield_default_values() (regel 375 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined variable: instance in addressfield_default_values() (regel 376 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined index: bundles in _addressfield_country_options_list() (regel 874 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Warning: Invalid argument supplied for foreach() in _addressfield_country_options_list() (regel 874 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined variable: instance in addressfield_default_values() (regel 377 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).
    Notice: Undefined variable: instance in addressfield_default_values() (regel 404 van /home/mysite/public_html/sites/all/modules/addressfield/addressfield.module).

As you can see the errors are related to the Addressfield Tokens module as the Address field module, so I'm not sure which one is causing the issue (feel free to move it if deemed appriopriate).

I wish I had more information on this in order ro reproduce it, but unfortuantely we have no idea why it suddenly popped up there (someone reported this to us).

The address fields are gone too, except for the select list to pick a country.

It happens to the currently recommended version as well as to the dev version.

Comment	File	Size	Author
#13	missing_argument-2434707-13.patch	2.74 KB	joel_osc
#4	missing_argument-2434707-4.patch	2.7 KB	joel_osc

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

knalstaaf CreditAttribution: knalstaaf commented 24 February 2015 at 17:42

Project:	Address Field	» Addressfield Tokens
Version:	7.x-1.x-dev	» 7.x-1.5

Disabling the Addressfield Tokens module drastically removes these errors (fields remain missing though), only this one persists, after disabling the Addressfield module as well:

Notice: Undefined index: addressfield in webform_component_include() (regel 4414 van /home/mysite/public_html/sites/all/modules/webform/webform.module).

Because the address fields weren't cleaned up after disabling the module. (Cleaning them up manually and clearing the cache fixes this.)

Comment #2

knalstaaf CreditAttribution: knalstaaf commented 24 February 2015 at 18:33

Don't want to get every possible party involved, but tokens in the e-mail template are using fields of the Webform layout module.

These tokens look like this: [submission:values:webformlayoutfield_machinename:fieldinlayoutbox_machinename]

This is how the tokens work with WFL, in order to get them printed in the e-mail. So it's not unthinkable that there's a struggle there.

Comment #3

richH CreditAttribution: richH commented 28 February 2015 at 22:35

MEGA PROBLEM!!
Just updated addressfield to latest version and now have these errors. Real big mucho problemo here...!
Rch

Comment #4

joel_osc CreditAttribution: joel_osc commented 8 March 2015 at 15:39

File	Size
missing_argument-2434707-4.patch	2.7 KB

I think this is a result of addressfield changing its default_values function to bring in $field and $instance - which I don't think we really have since this is a webform component. I have created a patch that just adds a local default_values function and also a new form element to allow the user to select a default country.

Comment #5

joel_osc CreditAttribution: joel_osc commented 8 March 2015 at 15:40

Category:	Support request	» Bug report
Status:	Active	» Needs review

Comment #6

owenpm3 CreditAttribution: owenpm3 commented 9 March 2015 at 20:08

#4 fixed the errors and I was able to select the default value for the country. That default was then carried into the webform correctly.

Based on what I've seen in other posts, you'll have to go back and fix any webform that had a previously declared default country as your data was lost with the latest upgrade of the addressfield module.

Comment #7

wylbur CreditAttribution: wylbur commented 12 March 2015 at 04:56

Status:

Needs review

» Reviewed & tested by the community

Applied the patch to a fresh install of Drupal 7.34 with addressfield and addressfield token module.

The patch in #4 resolved the errors. Marking as RTBC.

Comment #8

scotwith1t

Birmingham, AL

CreditAttribution: scotwith1t commented 7 April 2015 at 14:53

+1 The new addressfield module definitely breaks the webform integration and this patch works quite nicely. Thanks!

Comment #9

Eli-T

he/him

English

Manchester

CreditAttribution: Eli-T commented 12 April 2015 at 14:43

Tested patch with #4 with Drupal 7.36, works fine.

Comment #10

Poieo CreditAttribution: Poieo commented 18 April 2015 at 18:37

This does resolve the error and provide a default value which is nice. But, it seems to force a default value. I'm not sure this is ideal in every situation?

Comment #11

Amad Tababa CreditAttribution: Amad Tababa commented 19 April 2015 at 15:12

Applied and Tested patch with #4 with Drupal 7.36, works fine.

Comment #12

joel_osc CreditAttribution: joel_osc commented 22 April 2015 at 13:56

@Poieo is correct, I will need to add the ability to not have a default country.

Comment #13

joel_osc CreditAttribution: joel_osc commented 22 April 2015 at 23:21

Status:

Reviewed & tested by the community

» Needs review

File	Size
missing_argument-2434707-13.patch	2.74 KB

Here is the same patch except that it also allows the default country not to be set. Please review, thanks!

Comment #14

fonant CreditAttribution: fonant commented 28 April 2015 at 13:38

Patch from #13 works nicely here, so I can set the default country per-field.

Comment #15

Sinan Erdem CreditAttribution: Sinan Erdem commented 28 May 2015 at 05:48

Patch from #13 works for me. Thanks for that.

Comment #16

victoriachan CreditAttribution: victoriachan commented 28 May 2015 at 14:21

Patch from #13 works for me too. Thanks very much.

Comment #17

28 May 2015 at 17:02

markie committed ac10e55 on 7.x-1.x authored by joel_osc

Issue #2434707 by joel_osc: Warning: Missing argument 2 for...

Comment #18

markie CreditAttribution: markie at Mediacurrent commented 28 May 2015 at 17:04

Status:

Needs review

» Fixed

Applied patch #13 and created dev branch / release. Once dev release is available, please open new issues against that.

Comment #19

11 June 2015 at 17:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #20

rparve@symphony3.com CreditAttribution: rparve@symphony3.com as a volunteer and commented 17 June 2015 at 05:01

Patch from #13 works for me too. Thanks very much.

Comment #21

aprilr CreditAttribution: aprilr commented 24 November 2015 at 21:49

#13 Patch worked great! Thanks!

Comment #22

dasginganinja

English

Bethlehem, PA

CreditAttribution: dasginganinja as a volunteer and commented 13 January 2016 at 16:15

I see that the patch is now in dev. Is there any sort of roadmap for when the next release of addressfield_tokens will be available?

Comment #23

deanflory CreditAttribution: deanflory as a volunteer commented 15 March 2016 at 09:27

Is that dev version going to be revealed on the project page? It currently does not show.

Comment #24

mccrodp CreditAttribution: mccrodp at X-Team for Pantheon commented 9 August 2016 at 12:53

You can get it from the git repo. The branch naming is wrong here if a dev release was intended for the project page. It would need to be a commit on the main 7.x branch.

https://www.drupal.org/node/1559772/git-instructions/7.x-1.x-dev/nonmain...