Probably would be better to remove "Media browser" widget from settings of image fields.

Reasons:

  • It causes unnecessary dependency on media module.
  • If needed the widget can be changed to "Media browser" widget by user anytime.
CommentFileSizeAuthor
#10 entity_background-media_browser-2434621-10.patch2.45 KBdabbor
#8 entity_background-media_browser-2434621-8.patch2.62 KBdabbor
#6 entity_background-media_browser-2434621-6.patch1.52 KBdabbor
#4 entity_background-media_browser-2434621-4.patch2.62 KBdabbor
#1 entity_background-media_browser-2434621-1.patch1.6 KBdabbor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dabbor’s picture

dabbor CreditAttribution: dabbor commented
Status: Active » Needs review
FileSize
entity_background-media_browser-2434621-1.patch1.6 KB

Attaching patch.

Removed the "Media browser" widget from default settings of image field.

dabbor’s picture

dabbor CreditAttribution: dabbor commented
Title: Default settings of field and image fields contains "Media browser" widget » Default settings of file and image fields contains "Media browser" widget
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: entity_background-media_browser-2434621-1.patch, failed testing.

dabbor’s picture

dabbor CreditAttribution: dabbor commented
Status: Needs work » Needs review
FileSize
entity_background-media_browser-2434621-4.patch2.62 KB

Attaching a new patch.

Set the file schema settings to all image fields.
Not sure why the patch before couldn't be applied. Tested locally again and all worked.

Status: Needs review » Needs work

The last submitted patch, 4: entity_background-media_browser-2434621-4.patch, failed testing.

dabbor’s picture

dabbor CreditAttribution: dabbor commented
Status: Needs work » Needs review
FileSize
entity_background-media_browser-2434621-6.patch1.52 KB

The patch contained some modifications to entity_background_image.info and entity_background_parallax.info. I removed them to test if they are causing the problem with applying the patch.

Status: Needs review » Needs work

The last submitted patch, 6: entity_background-media_browser-2434621-6.patch, failed testing.

dabbor’s picture

dabbor CreditAttribution: dabbor commented
Status: Needs work » Needs review
FileSize
entity_background-media_browser-2434621-8.patch2.62 KB

Removed the allowed_schemes settings from the patch.

Applied patch locally + run all tests and all was OK (not sure why the drupal test bot reports problem).

Status: Needs review » Needs work

The last submitted patch, 8: entity_background-media_browser-2434621-8.patch, failed testing.

dabbor’s picture

dabbor CreditAttribution: dabbor commented
Status: Needs work » Needs review
FileSize
entity_background-media_browser-2434621-10.patch2.45 KB

Fixed inconsistent patch markup after manual update.

Status: Needs review » Needs work

The last submitted patch, 10: entity_background-media_browser-2434621-10.patch, failed testing.

  • Ivan Zugec committed a38d526 on 7.x-1.x authored by dabbor 
    Issue #2434621 by dabbor: Default settings of file and image fields...
Ivan Zugec’s picture

Ivan Zugec CreditAttribution: Ivan Zugec commented
Status: Needs work » Fixed

Thanks @dabbor.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.