Hi, do you have any plans on upgrading this module to a full project?

Comments

mparker17’s picture

I could, but it only works with an unreleased version of the Smiley module (7.x-2.x), and I haven't tested it in a long time, so I don't know whether either still work.

I can put some time into this for you though.

mparker17’s picture

Assigned: heylookalive » Unassigned
Status: Active » Needs review
heylookalive’s picture

I'd be very grateful if you could! :) Many thanks!

mparker17’s picture

Okay.

Despite the fact that I maintain two other projects, I don't actually have permission to create full projects, so I need to apply for that first. That process will take probably a week or two. As soon as I have it, I'll promote this project and make a release.

@heylookalive, are you interested in becoming a co-maintainer of this project?

mparker17’s picture

The application is here: #2441927: [D7] Smiley Emoji

I plan to do the review bonus program this week, then mark the issue as Needs Review when I'm done, which should speed up the process.

@heylookalive, if you have any comments in support of the application, please add them. It may help speed the application process along.

mparker17’s picture

Related issues: +#2441927: [D7] Smiley Emoji
leewoodman’s picture

hi, any progress with this one, really keen to use this module on our site. thanks

mparker17’s picture

@leewoodman and @heylookalive,

I now have access to make a full release for this project, but my co-worker @t0xiccode pointed out a bug: my module doesn't read smileys containing special characters properly (e.g.: the thumbs-up symbol, :+1:, would not work as expected).

This means that comments or body text written now might not work after I fix the bug, and because there's no way to write a reliable update path without side-effects, I'd like to hold off on releasing the module until that is done.

I am working on this bug right now though.

Once the bug is fixed and I'm satisfied, I will release a beta version of the module, then work on automated tests. Once automated tests are in, I plan to move the module to a release-candidate, and if no new bugs are found in a month, I'll release a 1.0 release version.

Joachim Namyslo’s picture

stumbled in here. Just wondering why there in no issue for that bug if it. is the only one blocking you from releasing a beta version of this nice module

mparker17’s picture

I hadn't added an issue because I was using this issue to track it...

But honestly, I haven't been able to work on this module for 9 months, due to an overwhelming amount of work and demands on my personal time.

@dinmikkith, are you interested in becoming a co-maintainer and helping move this module forward to release?

Joachim Namyslo’s picture

Well, I have never done code for dual but it may be time to grab my coding skills from the shelf and do something awesome. So yes if you like to give me access to the code I'll clone it and start to figure out some issues.

mparker17’s picture

@dinmikkith, awesome! :) Thank you very much: this takes a load off of my mind!

I've given you full project maintainer access, including push access to the repository.

You can clone any project from the project's Version Control tab; but when you go to that tab in this project, you'll now see a "Maintainer?" checkbox which, when you check it and click the "Show" button, will show you how to clone the project via authenticated SSH.

If (and only if) you already had an anonymous https clone of the module, you'll need to change the git remote on your local project. If you need to do this, let me know and I'll send the commands you need to run.

If you haven't done this already, you might need to agree to Drupal.org's Git access agreement. To do this, go to https://www.drupal.org/user , click "Edit", then "Git access", then, under "Git access agreement", check "I agree to these terms". One of these terms is that you are not allowed to commit code, images, etc. unless they are GPL2+-licensed (this is why this project uses the Libraries API to include the smileys, instead of committing the smileys to the repository directly).

***

When I started maintaining projects, I was kind-of nervous about pushing code. If you'd prefer, you can upload patches for me to review -- it's usually easier for me to find the time to review patches, so I'll do my best to keep things moving quickly if you'd prefer to use this method.

***

Just a note, I'd very much prefer that this project conforms to the Drupal Coding and Documentation standards. Check out my article on how to install / use the PHPCodeSniffer tool for more information.

***

Finally, if you have any questions, please post them to this queue, or send me an email using the contact form on my user profile page. I'm happy to help how I can!

Joachim Namyslo’s picture

Well, got it. Thank you I'll do the best I can to bring this forward.

Thanks a lot!