Problem/Motivation

BlockTemplateSuggestionsTest makes no HTTP requests but is a functional test

Proposed resolution

Convert BlockTemplateSuggestionsTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#22 2432647-22.interdiff.txt595 bytesclaudiu.cristea
#22 2432647-22.patch2.65 KBclaudiu.cristea
#19 2432647-19.patch2.65 KBclaudiu.cristea
#15 2432647-15.patch771 bytesyogeshmpawar
#10 2432647-10.patch759 bytesneerajsingh
#1 2432647.1-do-not-test.patch676 bytesYesCT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
2432647.1-do-not-test.patch676 bytes

applies on top of #1847280: Simpletest web tests misnamed as "Unit"

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Needs work

BlockTemplateSuggestionsTest is currently a BrowserTestBase test, converted automatically in #2770921: Feb 21st: Convert chunk of WTB to BTB by just moving classes, changing use statements adding traits

It could probably still be a KTB test.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Issue tags: +Novice
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
CreditAttribution: neerajsingh commented
Assigned: Unassigned » neerajsingh

Working on the updated patch.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
CreditAttribution: neerajsingh commented
Assigned: neerajsingh » Unassigned
FileSize
2432647-10.patch759 bytes
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
CreditAttribution: neerajsingh commented
Status: Needs work » Needs review

The last submitted patch, 1: 2432647.1-do-not-test.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 10: 2432647-10.patch, failed testing. View results

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
FileSize
2432647-15.patch771 bytes

converted back to KTB test.

Status: Needs review » Needs work

The last submitted patch, 15: 2432647-15.patch, failed testing. View results

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Parent issue: #1847280: Simpletest web tests misnamed as "Unit" » #3041700: [META] Convert some tests into Kernel or Unit tests
Related issues: +#1847280: Simpletest web tests misnamed as "Unit"

Changing parent.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Title: change BlockTemplateSuggestionsTest to be a KernelTestBase » Convert BlockTemplateSuggestionsTest into a KernelTestBase
Version: 8.6.x-dev » 8.8.x-dev
Component: simpletest.module » system.module
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Novice +Test suite performance
FileSize
2432647-19.patch2.65 KB

This patch decreases the locally test run from 5.3 to 1.3 seconds. No interdiff as is not relevant. Fixed IS, title, tags, component.

Status: Needs review » Needs work

The last submitted patch, 19: 2432647-19.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented

1. Random test failure in #20.
#3045612: Random test failure in MediaStandardProfileTest::testMediaSources

2. Coding standards so patch still "Needs work".

--- modules/block/tests/src/Kernel/BlockTemplateSuggestionsTest.php
+++ PHP_CodeSniffer
@@ -47,7 +47,7 @@
       'block__system',
       'block__system_menu_block',
       'block__system_menu_block__admin',
-      'block__machinename'
+      'block__machinename',
     ], $suggestions);
   }
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Needs work » Needs review
FileSize
2432647-22.patch2.65 KB
2432647-22.interdiff.txt595 bytes

Thanks. Fixed.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Since this is dependant on ordering, queued for PHP5.5, assuming that passes, this conversion looks good.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed a40b387 and pushed to 8.8.x. Thanks!

  • catch committed a40b387 on 8.8.x 
    Issue #2432647 by claudiu.cristea, neerajsingh, YesCT, yogeshmpawar,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.