Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Coder says there are some potential problems with code:
SITES/ALL/MODULES/CONTRIB/NODE_GALLERY/NODE_GALLERY_API.ADMIN.INC
node_gallery_api.admin.inc
severity: criticalLine 284: Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
'#title' => $label,
And
node_gallery_api.pages.inc
severity: criticalLine 37: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)
drupal_set_message(t('There are too many images in this gallery to display. You can increase the limit by !settings_url. The current limit is !max.', array('!settings' => 'admin/config/content/node-gallery/settings', '!max' => $max_image_count)), 'warning');
severity: normalLine 118: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
$exif = null;
severity: criticalLine 184: Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
drupal_set_message($message);
Comment | File | Size | Author |
---|---|---|---|
#1 | potentialproblems.patch | 2.12 KB | RavindraSingh |
Comments
Comment #1
RavindraSingh CreditAttribution: RavindraSingh commentedI have fixed the potential problems for this module.
Updated the patch for the same. There are some other small problems also exist. which doesn't require any fix.
Comment #2
RavindraSingh CreditAttribution: RavindraSingh commentedComment #4
zengenuity CreditAttribution: zengenuity commentedThanks. Committed.