Coder says there are some potential problems with code:

SITES/ALL/MODULES/CONTRIB/NODE_GALLERY/NODE_GALLERY_API.ADMIN.INC
node_gallery_api.admin.inc

severity: criticalLine 284: Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
      '#title' => $label,

And

node_gallery_api.pages.inc

severity: criticalLine 37: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)
    drupal_set_message(t('There are too many images in this gallery to display. You can increase the limit by !settings_url. The current limit is !max.', array('!settings' => 'admin/config/content/node-gallery/settings', '!max' => $max_image_count)), 'warning');
severity: normalLine 118: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
  $exif = null;
severity: criticalLine 184: Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
  drupal_set_message($message);
CommentFileSizeAuthor
#1 potentialproblems.patch2.12 KBRavindraSingh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RavindraSingh’s picture

FileSize
2.12 KB

I have fixed the potential problems for this module.

Updated the patch for the same. There are some other small problems also exist. which doesn't require any fix.

RavindraSingh’s picture

Status: Active » Needs review

zengenuity’s picture

Status: Needs review » Fixed

Thanks. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.