Based on discussions in #2090115: Don't install a module when its default configuration has unmet dependencies going to try to move all optional configuration to a different directory.

Test-only issue - please don't post reviews

Files: 
CommentFileSizeAuthor
#9 2431275.9.patch69.3 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 87,317 pass(es). View
#9 7-9-interdiff.txt646 bytesalexpott
#7 2431275.7.patch68.67 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 87,331 pass(es), 0 fail(s), and 1 exception(s). View
#7 5-7-interdiff.txt11.37 KBalexpott
#5 3-5-interdiff.txt2.37 KBalexpott
#5 2431275.5.patch57.63 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,737 pass(es), 25 fail(s), and 30 exception(s). View
#3 2431275.3.patch57.67 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,213 pass(es), 1,107 fail(s), and 63,348 exception(s). View
#1 2431275.1.patch57.62 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2431275.1.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

alexpott’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
57.62 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2431275.1.patch. Unable to apply patch. See the log in the details link for more information. View

I love this change - reading the code in the configuration installer it's so much easier to understand. Personally I think we should roll this work into #2090115: Don't install a module when its default configuration has unmet dependencies since it solves the problem of unmet dependencies and optional configuration completely. That said, I'm posting patches on this issue to get it green before going back to that issue. So no need for reviews on this issue at this point.

Status: Needs review » Needs work

The last submitted patch, 1: 2431275.1.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
57.67 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,213 pass(es), 1,107 fail(s), and 63,348 exception(s). View

Status: Needs review » Needs work

The last submitted patch, 3: 2431275.3.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
57.63 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,737 pass(es), 25 fail(s), and 30 exception(s). View
2.37 KB

Used a PHP 5.6 only thing :(

Status: Needs review » Needs work

The last submitted patch, 5: 2431275.5.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
11.37 KB
68.67 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 87,331 pass(es), 0 fail(s), and 1 exception(s). View

This should fix all the tests.

  • For the webtest fails we have modules which did not correctly declare their dependencies - for example block_test is not dependent on block.
  • For kerneltest fails we need to install the configuration for the thing we're testing rather than relying on the the magic find all the configuration in already install modules.
  • The KernelTestBaseTest failure were interesting because module_test depends on node which depends on user which depends on system. The user module needs the dependency on system because it provides system.action. configuration entities and the kernel test base environment is special because system is not installed unless you tell it to be :)

Status: Needs review » Needs work

The last submitted patch, 7: 2431275.7.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
646 bytes
69.3 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 87,317 pass(es). View

One more thing...

alexpott’s picture

alexpott’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.