Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Want to have automatically updated JWplayer library.
Proposed resolution
Load the JWPlayer library directly from CDN when an account key is set.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#5 | jw_player-2430231-5.patch | 2.8 KB | tonnosf |
#1 | jw-player-2430231-1.patch | 1.3 KB | tonnosf |
Comments
Comment #1
tonnosf CreditAttribution: tonnosf commentedDone follow changes:
- JWPlayer load first from CDN when account key is set
- Removed base setting when load from CDN
Comment #3
BerdirThis condition already exists, below. Was confused a bit, but I see it now, it also use external when a local version is present when account token is set.
In that case, instead of adding it a second time, you should move the elseif below above if ($info['installed'] and make that the elseif.
Also, the test needs a slight adjustment now, the base part needs to be removed from the expected configuration.
Comment #4
tonnosf CreditAttribution: tonnosf commentedComment #5
tonnosf CreditAttribution: tonnosf commentedDone follow changes:
- Unset base setting when an account token is set
- Add CDN load as first condition before if ($info['installed'])
- Removed jwplayer base setting in test
Comment #7
BerdirThanks, looks good now, committed.
Comment #8
Perignon CreditAttribution: Perignon commentedVery interesting. This did not exist about six months ago when I started on a new project to build a specialized JW Player. I was creating a custom module then I decided to start a sandbox here to see if anyone else would be interesting. I take the CDN loading to an extreme loading everything about the videos off CDN to include the videos themselves all using signed cloudfront URLS. It's an extreme use case. You can see what I am working on here:
https://www.drupal.org/sandbox/perignon/2396521
I will have development of the module completed within 30 days as I have a deadline to meet with a client that requires it.
Let me know what you think. My plan was to reach out to you guys to see if there are any synergies between us. I have borrowed a lot of code from your module.