The oa_workbench_moderation_state pane tries to remove the workbench_moderation_state_new field from existing node forms and stick it in a dedicated pane. This works if that pane loads before the "publishing options" pane. But in some cases (I haven't been able to tell exactly how/why it happens), the oa_workbench_moderation_state pane is built AFTER the node_form_publishing pane, meaning that it's trying to remove an element from the form too late, which leads to that element being duplicated. Screenshot: http://note.io/1LeGu7K
A quick fix for this is to make oa_workbench_moderation_state only do the replacement if #access hasn't already been set to FALSE for that form element (which is what the node_form_publishing does when it's building). This at least makes oa_workbench smart enough to say "oops, I'm too late to unset that field, so I'll just avoid adding my own".
Patch incoming.
Comment | File | Size | Author |
---|---|---|---|
#2 | oa_workbench_2429529_2_dupe_pane.patch | 1.06 KB | mcrittenden |
#1 | oa_workbench_2429529_1_dupe_pane.patch | 805 bytes | mcrittenden |
Comments
Comment #1
mcrittenden CreditAttribution: mcrittenden commentedComment #2
mcrittenden CreditAttribution: mcrittenden commentedUpdated patch that uses 'render first' to try to force it to be first.
Comment #3
Argus CreditAttribution: Argus as a volunteer commentedBumping another needs review.
Comment #4
Grayside CreditAttribution: Grayside at Phase2 commentedLooks like this was committed already.
http://drupalcode.org/project/oa_workbench.git/commit/116038a