panels_mini_contextual_links_view_alter tries to add contextual_links on mini panels printed through drupal regions system as a block, but checks for ['#block']->bid which it should be integer usually not sure if there a case where it is a string, replacing with ['#block']->module check for 'panels_mini' should be sufficient to check to make sure it is a mini_panels block.

CommentFileSizeAuthor
#13 panels-mini_panels_block_contextual_links-2427917-13.patch1.21 KBmqanneh
#1 panels-mini_panels_blocks_contextual_links-2427917.patch810 bytesalaa abbad
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alaa abbad’s picture

alaa abbad CreditAttribution: alaa abbad commented
FileSize
panels-mini_panels_blocks_contextual_links-2427917.patch810 bytes
alaa abbad’s picture

alaa abbad CreditAttribution: alaa abbad commented
Status: Reviewed & tested by the community » Needs review
alaa abbad’s picture

alaa abbad CreditAttribution: alaa abbad commented
Title: Contextual links for mini panels placed as blocks. » Contextual links for mini panels.
Related issues: +#1966020: Contextual links for mini panels placed as blocks., +#2196091: Notice: Undefined property: stdClass::$bid in panels_mini_contextual_links_view_alter()
alaa abbad’s picture

alaa abbad CreditAttribution: alaa abbad commented
Title: Contextual links for mini panels. » Mini Panels block contextual links test for bid instead of module name.
Assigned: alaa abbad » Unassigned

.

alaa abbad’s picture

alaa abbad CreditAttribution: alaa abbad commented
Issue summary: View changes
Jon Nunan’s picture

Jon Nunan CreditAttribution: Jon Nunan at Flight Centre Travel Group commented

Came across the same problem today, and it seems the original programmer also thought it should have worked this way:
https://www.drupal.org/node/1966020#comment-7281158

Perhaps a bug got fixed somewhere else? Anyway this patch fixes my use case, I think maybe you should have left the first
isset($element['#element']['#block']) in the conditional though to prevent warnings on non-block conditional links being processed. And I don't think it still needs to be a strpos, can just be a straight string comparison right?

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Drupal Association commented
Version: 7.x-3.5 » 7.x-3.x-dev

Looks like this one needs attention and is fairly easy to fix. Bump.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

+1

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Parent issue: » #2787081: Plan for Panels 7.x-3.8 release
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

Tested - Still works with Panels 7.x-3.8 release

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Status: Needs review » Reviewed & tested by the community
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs tests

Needs more testing and test results before being committed.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
CreditAttribution: mqanneh as a volunteer and at Vardot commented
FileSize
panels-mini_panels_block_contextual_links-2427917-13.patch1.21 KB

Rerolling the patch against the most recent dev version.