Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Shortcut module is using shortcut_set_assign_user and shortcut_set_unassign_user global functions.
As per tstoeckler for removing global functions -
it is a good idea. it's the new world order
Proposed resolution
Remove global functions
Fix the test coverage
Remaining tasks
User interface changes
None
API changes
Beta phase evaluation
Issue priority | Not critical because Drupal is fully functional with these two global functions |
---|---|
Unfrozen changes | Not unfrozen |
Prioritized changes | This is not a prioritized change, however we are only deprecating functions for drupal 9.x and removing the usages. |
Disruption | No disruption. |
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff.txt | 1.78 KB | kgoel |
#13 | 2427323-13.patch | 4.19 KB | kgoel |
#10 | interdiff.txt | 1.68 KB | kgoel |
#10 | 2427323-10.patch | 4.06 KB | kgoel |
#5 | interdiff.txt | 685 bytes | kgoel |
Comments
Comment #1
kgoel CreditAttribution: kgoel commentedRemoved some unused classes as well...
Comment #2
kgoel CreditAttribution: kgoel commentedComment #4
tstoecklerShould be
$this->adminUser
instead of$this->shortcutUser
.Comment #5
kgoel CreditAttribution: kgoel commentedComment #6
kgoel CreditAttribution: kgoel commentedComment #7
kgoel CreditAttribution: kgoel commentedComment #8
tstoecklerAwesome, thanks!
Comment #9
alexpottTime has passed for this type of change. We can deprecate for drupal 9.x and remove usages but there is no need to break the API.
Comment #10
kgoel CreditAttribution: kgoel commentedComment #11
dawehnerLet's nitpick a bit :)
Afaik we place those @deprecated tags onto the bottom of the doc block.
Comment #12
kgoel CreditAttribution: kgoel commentedIn that case, this must be wrong in core...
Comment #13
kgoel CreditAttribution: kgoel commentedComment #14
tstoecklerLooks good to me, thanks for sticking with this!
Comment #15
kgoel CreditAttribution: kgoel commentedComment #16
alexpottCommitted 4211782 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.