Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The module stores a list of the favicons as an array in a variable, however it also stores a line break in each string. It shouldn't store the line endings and instead should add them at runtime.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | responsive_favicons-n2427209-2.patch | 2.06 KB | DamienMcKenna |
Comments
Comment #1
DamienMcKennaThis ought to do it - it removes the EOL character from each tag, and removes the empty item at the end of the array.
Comment #2
DamienMcKennaFixed a typo.
Comment #3
wiifmHey Damien, this all looks sane, will look at testing this and getting this committed sometime today. Thanks so much for the patch!
Comment #4
sjpagan CreditAttribution: sjpagan commentedHi i'm tired install your module, but after installazuine don't work fine.
In my case i dont see the correct href under link attribute, and i see in the report bug the next result on incons not found:
Responsive favicons not found
In my case the web server installed on mac and the root of sites folder is : http://localhost and the root of drupal site is : http://localhost/www.drupal.org.
What could be the problem ?
Comment #5
DamienMcKenna@sgpagan: Please open a new issue rather than taking over an existing one.
Comment #7
wiifmThanks Damien, appreciate the patch. This is now committed (with authorship).