Instead of local libraries I would like to use the css from the CDN.

CommentFileSizeAuthor
#12 add_support_for_cdn-2427075-12.patch900 bytesmkhamash
#7 add_support_for_cdn-2427075-7.patch2.83 KBmkhamash
#3 use-cdn-instead-of-local-library-2427075-3.patch1.89 KBwroxbox
#2 use-cdn-instead-of-local-library-2427075-2.patch814 byteswroxbox
#1 use-cdn-instead-of-local-library-2427075-1.patch1.09 KBwroxbox
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wroxbox’s picture

wroxbox CreditAttribution: wroxbox commented
FileSize
use-cdn-instead-of-local-library-2427075-1.patch1.09 KB

Changed preprocess_page into hook_page_build and added CSS from CDN.

wroxbox’s picture

wroxbox CreditAttribution: wroxbox commented
FileSize
use-cdn-instead-of-local-library-2427075-2.patch814 bytes

Fixed to latest CDN version.

wroxbox’s picture

wroxbox CreditAttribution: wroxbox commented
FileSize
use-cdn-instead-of-local-library-2427075-3.patch1.89 KB
SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

Could there be a switch where an admin can decide which s/he would like with a local library fallback much like jquery_update?

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented
Status: Active » Needs review
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Title: Use Fontawesome from CDN » Add support for CDN version of Font Awesome
Status: Needs review » Needs work

This completely replaces the ability to provide a local version.

mkhamash’s picture

mkhamash CreditAttribution: mkhamash at Vardot commented
Status: Needs work » Needs review
Related issues: +#864376: Loading of external libraries
FileSize
add_support_for_cdn-2427075-7.patch2.83 KB

Here is patch that will give the ability to choose between a local and a CDN version of Font Awesome, it adds a checkbox to Drupal Bandwidth optimization settings in performance page, I am not convinced with the place of the checkbox but this is the best place that I could find.

aDarkling’s picture

aDarkling CreditAttribution: aDarkling as a volunteer commented

Works great!

Tried it with css/jscript aggregation on & off.
Code looks good. You might want to compress lines 20-22 to

$requirements['fontawesome']['title'] = $fontawesome['name'];

for code readability consistency, especially since the array was already explicitly defined on line 12.
However that is just a personal style opinion & does not affect the operation of this patch in the least.

inders’s picture

inders CreditAttribution: inders commented
Assigned: Unassigned » inders
Status: Needs review » Reviewed & tested by the community

  • mkhamash authored 98c031c on 7.x-2.x 
    Issue #2427075 by wroxbox, mkhamash: Add support for CDN version of Font...
inders’s picture

inders CreditAttribution: inders commented
Status: Reviewed & tested by the community » Closed (fixed)
mkhamash’s picture

mkhamash CreditAttribution: mkhamash at Vardot commented
FileSize
add_support_for_cdn-2427075-12.patch900 bytes

There was a small mistake in the hook_requirements() message in the original patch that I have uploaded, it would show a warning message "The Font Awesome library could not be found" with using the CDN option.

mkhamash’s picture

mkhamash CreditAttribution: mkhamash at Vardot commented
Assigned: inders » Unassigned
Status: Closed (fixed) » Needs review

  • mkhamash authored 72d824c on 
    Issue #2427075 by wroxbox, mkhamash: Add support for CDN version of Font...
inders’s picture

inders CreditAttribution: inders commented
Status: Needs review » Closed (fixed)

Commit done . Thank you mkhamash !