Max Pogonowski (db70b3e3) at 23 Mar 08:06
Issue #3407882 by darvanen, bobi-mel, thakurnishant_06, deepakkm, b...
Related to #3407882
Related to #3407882
Max Pogonowski (9257fec0) at 23 Mar 07:32
Issue #3418361 by darvanen, bobi-mel: Add and configure ESLint to G...
Related to #3418361
Related to #3418361
Max Pogonowski (2f64ccab) at 23 Mar 01:18
Issue #3407882 by bobi-mel, darvanen, thakurnishant_06, deepakkm, b...
Related to #3407882
Max Pogonowski (942cce03) at 13 Mar 23:22
Issue #3418295 by darvanen, bobi-mel, D-XPERT: stylelint
Related to #3418295
Max Pogonowski (ad6ada9f) at 13 Mar 21:38
Issue #3418294 by bobi-mel, darvanen: Fix test for D10 core
Related to #3418294
Related to #3295655
When you manually run a task, its matrix has defined parameters. However, two similar tasks, one tests the minimally compatible version of the PCP and the other the maximally compatible version of the PCP with the current Drupal kernel. In my opinion, this will provide optimal test coverageю
I asked in the #testing channel on Slack and everyone who replied effectively said: "ignore as little as possible, that is the core way". They also provided an example from core: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/tests/Drupal/Tests/Core/Test/TestSuiteBaseTest.php?ref_type=heads#L130
І think it will be better to follow the Drupal core way
You appear to be using a parallel job needlessly here as there is only one item in the matrix. Also see https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-drupal/gitlab-ci#s-known-problems - we may wish to be able to trigger jobs manually.
Related to #3418294
If it's just one method, would it be possible to use @phpstan-ignore-line
in the test class instead?
We have disabled not the taest itself but the PHPStan check for it. The test will still run as before, but there will be no errors about PHPStan non-compliance. Unfortunately, I have not found an alternative to the outdated method. We will be able to enable PHPStan checking in the future.