CiteProc is not outputting editor nor translator labels in citations

Attached is a patch for reversing the commit that caused the labels to go away.

The commits that caused the labels to go away were trying to prevent all labels from showing unless there was a value assigned to the field. The labels continue to be hidden on fields with no values even after reverting the commits that caused the breakage.

It came down to this code. Lines 1184 - 1189 in CSL.inc

      $field = $this->citeproc->map_field($variable);

      if ((isset($data->$field) && !empty($data->$field)) && ($term = $this->citeproc->get_locale('term', $variable, $form, $plural))) {
        $text = $term;
        break;
      }

The check for the $field on $data always fails because $data is an array with multiple items. eg $data[0] = (object); $data[1] = (object);
I went back to rc4 as that was the last previous version that worked without additional patches to see what was in the $data and $field values. It is consistent with the latest release of rc7.

Do we need to keep this check?

New patch attached for latest dev.

Simplifying the label render function and plural evaluation.

Both patches 5 & 6 are removing CSL functionality. The code is not obvious, but there are two "plural" variables. $this->plural is referring to the plural attribute in the cs:label element of the CSL spec... http://citationstyles.org/downloads/specification.html#label

Thanks for the speedy feedback. Attached is another try at simplifying the pluralization check.

OK, so I've tracked down and fixed (I think) this issue. Just need to do a little more testing to make sure the fix didn't break anything else.

Would anyone care to test the attached patch. I believe it resolves the original issue.

Thank you.