The panopoly_admin module contains a lot of css that is very theme-specific. This css (especially for buttons) should be moved into panopoly_theme.

Currently the Radix theme disables the panopoly_admin.css because of this.

In general, there shouldn't be anything related to colors, background gradients, fonts, etc in a module's css file. The module css is responsible for css that defines the functionality, such as layout, float, margins, etc to provide a default operational look & feel. Stuff to make it look "fancier" should be reserved for the theme.

In this case, Radix uses Bootstrap which has specific styles for buttons. Panopoly_admin is overriding that.

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Component: Theme » Admin

I agree with the this! However, unfortunately, we can't just remove the CSS, we have to try not to cause unexpected changes on existing sites that upgrade.

I'd propose that we keep this CSS as part of the panopoly_admin module, but put it in a seperate CSS file that is only optionally loaded.

I'm not entirely sure what the default should be... If we just wanted to deprecate these styles, we could default to not including that CSS file and have a hook_update_N() that just turns it on for existing sites. Or we could default to including it, and then users can turn it off and themes can easily disable it entirely (like Radix) but without disabling everything that panopoly_admin does.

Anyway, I'll need to think about the default some more and probably get some input from the other maintainers...

populist’s picture

populist CreditAttribution: populist commented

I am not so sure. Most of the CSS in panopoly_admin.css (http://cgit.drupalcode.org/panopoly_admin/tree/panopoly-admin.css) is directly related to the way the #node-edit form is laid out which works in conjunction with the node/%/edit panel that is provided.

Totally fine with this code being conditional or with documentation provided in how to remove it, but I think it is a smart default for edit pages that should be maintained.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Issue summary: View changes

Thanks, @populist!

We're not talking about the CSS that affects how the form is laid out. Per @mpotter:

In general, there shouldn't be anything related to colors, background gradients, fonts, etc in a module's css file. The module css is responsible for css that defines the functionality, such as layout, float, margins, etc to provide a default operational look & feel.

So, this is about moving "anything related to colors, background gradients, fonts, etc" to a seperate CSS file that's easy to disable. But leaving everything else alone.

The biggest questions for me are:

  • Should this CSS file be enabled or disabled by default? Certainly, we should leave it enabled for existing sites, but what should it be for new sites?
  • Where should this live: in panopoly_admin (for easy backcompat) or panopoly_theme (where visual appearance stuff would make sense)?