Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In the D7 version of Scheduler we had a feature intended for a rare edge case: it allowed people to clean up their database tables in case they had deleted some scheduled nodes when the Scheduler module was temporarily disabled. This would cause orphaned database rows to remain behind in the scheduler table.
This edge case cannot occur any more in Drupal 8 since it is no longer possible to disable modules.
We should remove the _scheduler_delete_row_confirm() form, its submit handler and all references to it.
Original report by legovaer
There is now an abstract base class(ConfirmFormBase) that implements FormInterface with specific methods that represent the parameters used by confirm_form().
The confirm_form() function has thus been removed.
Read more about FormInterface here: http://drupal.org/node/1932058
Change records: Removed confirm_form() in favor of \Drupal\Core\Form\ConfirmFormBase
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2422825-3.patch | 3.85 KB | pfrenssen |
Comments
Comment #1
legovaerCreated new class DeleteForm inside namespace Drupal\scheduler\Form
Comment #2
pfrenssenThis conversion looks very good but I'm afraid that we will not need this functionality any more in Scheduler 8.x-1.x.
This was a feature intended for a rare edge case: it allowed people to clean up their database tables in case they had deleted some scheduled nodes when the Scheduler module was temporarily disabled. This would cause orphaned database rows to remain behind in the scheduler table.
This edge case cannot occur any more in Drupal 8 since it is no longer possible to disable modules.
I suggest we change the scope of this to remove this form and all references to it.
Comment #3
pfrenssenComment #5
pfrenssenCommitted to 8.x-1.x.