Problem/Motivation

Nodewords basic module provides set of fields without an option to select necessary field(s).

Proposed resolution

Provide a global settings for basic module to allow to select tags.

Remaining tasks

Discuss

User interface changes

Depends on the solution, we might have a new UI or alter existing one.

API changes

N/A

Comments

vijaycs85’s picture

Issue summary: View changes
DamienMcKenna’s picture

Title: Provide option to enable/disable basic tags » Provide option to disable specific tags
Component: Code » Tag editing
Category: Task » Feature request

First off, you should start with the v1 codebase, v2 is unsupported and won't get any further work.

I suggest that this should a) add a new variable to control which meta tags are disabled (and remove the variable in nodewords_uninstall()), b) add code to nodewords_get_possible_tags() to remove the disabled tags.

vijaycs85’s picture

Version: 6.x-2.x-dev » 6.x-1.x-dev
Status: Active » Needs review
FileSize
4.87 KB

Thanks @DamienMcKenna for the quick response and idea of how to do this. Here is the first try.

Status: Needs review » Needs work

The last submitted patch, 3: nodewords-2422701-disable-tags-3.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
4.85 KB
425 bytes

hah, copy/paste of test permission...

Status: Needs review » Needs work

The last submitted patch, 5: nodewords-2422701-disable-tags-5.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
4.85 KB
522 bytes

Another typo...

pacproduct’s picture

This looks like what I need :)

That seems to be the right approach from a performance perspective, and the patch looks good to me.
Just a small typo in function nodewords_get_possible_tags():

+++ b/nodewords.module
@@ -898,6 +901,10 @@ function nodewords_get_possible_tags($load = FALSE) {
+   $allowed_tags = array_filter(variable_get('nodewords_disabled', array()));

=> Minor: One indentation space missing here.

vijaycs85’s picture

thanks for the review @pacproduct. here is an update that fixes #8.

pacproduct’s picture

Thanks Vijaycs85.
Looks OK.