I just tried to install your module on d8 and got the following error see attached image for more information.

Fatal error: Class Drupal\coffee\Form\CoffeeConfigurationForm contains 1 abstract method and must therefore be declared abstract or implement the remaining methods

I implemented the extra method in the CoffeeConfigurationForm class see patch

protected function getEditableConfigNames() {
		
 }
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yannickoo’s picture

Status: Active » Needs review
FileSize
2.9 KB

Sorry but your patch includes lots of unnecessary file permission changes. I have added a new patch without these changes. It adds a method comment as well.

yannickoo’s picture

FileSize
885 bytes
Purencool’s picture

FileSize
33.57 KB
79.57 KB
28.56 KB

I don't mind fix the patch all you like. I applied coffee-form_error-2422621-2.patch on a new d8 install and it displayed the following error. After I refreshed the page the module says it is installed. See attached images
step-one,
error-displayed,
step-two

yannickoo’s picture

Purencool’s picture

Status: Needs review » Closed (fixed)
michaelmol’s picture

Status: Closed (fixed) » Closed (duplicate)