It's really hard to see visual difference between published comments and unpublished comments in Drupal 8. First one is published and second one is unpublised.
Drupal 7 had these styles for unpublished comments....
Drupal 8 currently looks like this....
Write a patch putting back the styles Drupal 7 had for unpublished comments.
2. Write a patch3. Review the patch
4. RTBC
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | bartik-comment-ux-fix-2422113-10.patch | 670 bytes | mrjmd |
| #9 | Screen_Shot_2015-02-11_at_12_18_24.png | 247.54 KB | emma.maria |
| #6 | drupal-8-comments.png | 276.35 KB | emma.maria |
| #6 | drupal-7-comments.png | 207.44 KB | emma.maria |
| #1 | bartik-comment-ux-fix-2422113-2.patch | 667 bytes | DickJohnson |
Comments
Comment #1
DickJohnson commentedRemoved comment-arrow border and added pink background.
Comment #2
DickJohnson commentedComment #3
DickJohnson commentedComment #4
DickJohnson commentedComment #5
DickJohnson commentedComment #6
emma.mariaThanks for working on this! You have uncovered a regression for comments needing approval in Drupal 8!
Turns out you have added the exact same styling that Drupal 7 has, so it does not need a usability review it is a regression bug. I have updated the issue summary to include what Drupal 7 was like and what Drupal 8 is now.
Comment #7
emma.mariaI added an annotation on the Drupal 8 screenshot in the issue summary. With the missing pink background we are currently left with
Comment #8
emma.mariaComment #9
emma.mariaComments needing approval now appear with the Drupal unpublished pink background. This is behaviour lost in Drupal 8 from Drupal 7.
Visually everything looks great...
However I found one small issue in the code....
Can you please remove the blank line left on line 100.
Thanks!
Comment #10
mrjmd commentedHere's a new roll with the extra white space removed.
Comment #11
DickJohnson commentedDid a testing with Safari, Firefox, Chrome and IE. Works as expected.
Comment #14
DickJohnson commentedRTBC'ed again after testbot stopped failing.
Comment #17
mrjmd commentedIt says it passed now, going to RTBC it yet again.
Comment #20
biigniick commented#10 passed again and seems to apply cleanly for me now.
Comment #21
alexpottCSS is not frozen in beta. Committed 48c2e66 and pushed to 8.0.x. Thanks!