There is a notice showing up.

Notice: Use of undefined constant firstChar - assumed 'firstChar' in _mytube_fixembedded()

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

grndlvl’s picture

Status: Active » Needs review
FileSize
993 bytes

Patched against 7.x-1.x dev but also applies agains 7.x-1.0-beta3.

milodesc’s picture

The previous patch fixed the undefined constant notice, but turned up another minor bug:

Once the dollar sign was added before 'firstChar' in the previous patch, the 'if' statement was properly evaluated which allowed the _mytube_add_param function to be called. The second argument supplied to that function was originally:
"$firstChar" . "autoplay=1"
where $firstChar was a question mark. But the _mytube_add_param function function already adds a question mark to the URL, so two question marks were being added to the URL.

This patch prevents the double question marks from occurring.

  • mfb committed 19bb9f4 on 7.x-1.x authored by milodesc
    Issue #2421701 by grndlvl, milodesc: Notice: Use of undefined constant...
mfb’s picture

Status: Needs review » Fixed
milodesc’s picture

grndlvl’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.