In the Media Browser under the "Library" tab, images are displayed at specified dimensions with the filename on layered top. Documents, however, are displayed as a link (also with the filename layered on top) and aren't limited to the same dimensions, ie. the link can extend outside.
Here's a screenshot:
While it's debatable if the preview for the document should even be a link, at the very least, that link (or anything else that could appear in the preview) shouldn't be able to extend outside of that box!
I'll post a patch to fix in a moment...
Original issue summary
Hi,
Just wondering, is the attached screen shot really the correct display for documents (word,pdf etc). The old style full sized icon to match image thumbnail dimensions was much more tidy and long filenames now make the layout extremely messy as they aren't being truncated.
Or has something not taken correctly when I've done the update?
Thanks
Dave
Comment | File | Size | Author |
---|---|---|---|
#3 | media-library-preview-overflow-2421589-3.patch | 1.79 KB | Devin Carlson |
#2 | media-library-preview-overflow-2421589-2.patch | 293 bytes | dsnopek |
#1 | Selection_039.png | 29.55 KB | dsnopek |
Comments
Comment #1
dsnopekComment #2
dsnopekHere is a patch to fix! Please let me know what you think. :-)
We're likely to start using this in Panopoly soon-ish.
Comment #3
Devin Carlson CreditAttribution: Devin Carlson commented@ritey, you're correct documents should be displayed using the 'Large filetype icon' formatter when viewed using the 'preview' view mode.
This is just a weight conflict between the default display configuration provided by Media vs. the one provided by File Entity. The attached patch adjusts the display weights so that they'll take precedence.
Comment #4
Devin Carlson CreditAttribution: Devin Carlson commentedTested #3 and committed to Media 7.x-2.x.
Comment #7
dsnopek@Devin Carlson: Thanks! That's actually a more elegant fix than just hiding the link overflow. :-)