The class EntityViewsData implements the interface EntityViewsDataInterface. That means that subclasses of EntityViewsData already implement the interface EntityViewsDataInterface. The subclasses should not implement the interface EntityViewsDataInterface themselves.

CommentFileSizeAuthor
#1 2420037-1.patch1.84 KBdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
FileSize
2420037-1.patch1.84 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2420037-1.patch, failed testing.

Status: Needs work » Needs review

daffie queued 1: 2420037-1.patch for re-testing.

daffie’s picture

daffie CreditAttribution: daffie commented
Title: Remove EntityViewsDataInterface from some subclasses » Remove EntityViewsDataInterface from some subclasses of EntityViewsData which implements EntityViewsDataInterface
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Good catches.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2420037-1.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

+1.

I kind of wish it made sense to need the interface declaration if the subclass overrides an implementation from the superclass, just so it would break spectacularly if the superclass changes its implementation or interface. But I think this works.

Status: Needs work » Needs review

daffie queued 1: 2420037-1.patch for re-testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a minor bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 99466a0 and pushed to 8.0.x. Thanks!

  • alexpott committed 99466a0 on 8.0.x 
    Issue #2420037 by daffie: Remove EntityViewsDataInterface from some...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.