[META] Improving SignatureField Module for D7 [#2418799]

I have updated the README.txt with more details on the installation of this module.
The hook_help was empty so I display the README.txt so we can have some information in the help pages.
In order to have this module working properly, we need to created a new directory in the libraries/signature-pad called build and move some files into it. This information is not either in the front page or in the README.txt I found this information in this comment. So I change it where this module do es not have to created or move any files just like the instruction in the front page.
I have fix this issue #2111849: Undefined idex: mandatory - Error message on above the form by replacing mandatory with required.
I have run the drush coder-format to add some spacing to make this module Drupal Coding Standards.

If you are running Webform 3x you should not apply this patch to this module otherwise you might run into some errors. You should also consider upgrading to Webform 4x and then applying this patch.

Log in or register to post comments

Comment #5

darol100 CreditAttribution: darol100 commented 11 March 2015 at 02:16

Status:

Active

» Needs review

Log in or register to post comments

Comment #6

darol100 CreditAttribution: darol100 commented 10 April 2015 at 14:30

Assigned:

darol100

» Unassigned

Log in or register to post comments

Comment #7

ogomez78 CreditAttribution: ogomez78 commented 17 April 2015 at 20:23

This patch worked wonderfully. Thanks!

Log in or register to post comments

Comment #8

21 April 2015 at 18:59

darol100 committed 601d507 on 7.x-2.x
```
#2418799: Improving SignaturedField.
```

Log in or register to post comments

Comment #9

emerham CreditAttribution: emerham as a volunteer commented 7 July 2015 at 17:38

Patch shows up for Webform version 4. Is there a way to do the textfield to signature like in the demo?
http://thomasjbradley.ca/lab/signature-pad/accept/

Log in or register to post comments

Comment #10

Morasta CreditAttribution: Morasta commented 5 August 2015 at 00:13

Was having problems getting SignatureField to function on my site, this patch takes care of it nicely. Would love to see it rolled into the dev branch.

Log in or register to post comments

The reason why did not commit this patch to the dev branch 7.x-1.x its because there are people using Webform 3x and this can break their website. That's why I created another branch 7.x-2.x with this issue been solve.

I do not have permission to created releases, so I can not make a release for 7.x-2.x. However, I can re-created another patch with the Webform 4.x changes without affecting the Webform 3.x and push it to 7.x-1.x .

I will do the same that I did on comment #4 but in separated issue. In addition, I have make this issue into a META issue to see if there are people interested on helping into this project.

Log in or register to post comments

Comment #12

Morasta CreditAttribution: Morasta commented 7 August 2015 at 18:27

@darol100,
Thanks for the explanation, that makes sense. I missed the fact there even was a 2.x branch.

Not sure if this other issue (https://www.drupal.org/node/2190471) is already addressed in that branch, but it appears the signaturefield won't render on a node's view unless the color, height, and width options are defined on the field itself. Happens on two dev sites in my environment.

The current help text implies they are optional, at least to me. Since someone took the time to open a issue about it, maybe it's worth patching that too? I just changed the text on my end and could provide a patch if it's worthwhile.

Log in or register to post comments

Comment #13

joelstein CreditAttribution: joelstein commented 1 October 2015 at 01:59

Thanks @darol100 for rolling these changes into the 7.x-2.x branch. It would be nice if we could get a release node so that folks can see the branch on the project page.

For those who want to work with these changes, you have to checkout the 7.x-2.x branch directly from Git:

https://www.drupal.org/project/signaturefield/git-instructions

Log in or register to post comments

Comment #14

joelstein CreditAttribution: joelstein commented 1 October 2015 at 02:20

File	Size
signaturefield-webform-conditional-fields-2418799-14.patch	1.15 KB

Since I'm not sure where to post patches against the 7.x-2.x branch, I'll post here. This patch fixes the Webform integration so that a Signature field can be shown/hidden with the Webforms conditional fields feature. It also removes the ability for a signature field to be used as a conditional field source (which wasn't working anyway).

Log in or register to post comments

Comment #15

themic8 CreditAttribution: themic8 at Trail 9 commented 8 January 2016 at 07:52

I am unable to access the repository for the 7.x-2.x branch.

Could you enable the 7.x-2.x branch on the project page?

Log in or register to post comments

Comment #16

darol100 CreditAttribution: darol100 commented 8 January 2016 at 10:39

Assigned:	darol100	» Unassigned
Category:	Task	» Plan
Status:	Needs review	» Active

@themic8, You have to download it using git. https://www.drupal.org/node/1012218/git-instructions/7.x-2.x/nonmaintainer

I do not have access to make releases, I message @realityloop (Brian, maintainer of this project) and he only gave me access to make new branches. I send him another message few months back to make a release for 7.x-2.x and he never reply me back =(.

I'm not using this module on any of my project, which makes me less interested on contributing back to this project. For this reason, I'm unassigned this issue so other people can work on it. Also, changing to plan since this is a meta, as well to "Active."

Log in or register to post comments

Comment #17

colan

he/him

English

Toronto 🇨🇦

CreditAttribution: colan at Colan Schwartz Consulting for Chapter Three commented 8 January 2016 at 16:54

Please read Dealing with unsupported (abandoned) projects for how to take over projects from unresponsive maintainers. Generally, they only have 2 weeks to get back to you, or it's yours.