I found a possible bug in ajaxView. ajaxView function will always create ajax object when attachBehaviors is triggered. This causes multiple ajax requests when RefreshView event is triggered. Here is the patch which should fix that.

CommentFileSizeAuthor
#13 views-refresh_multiple_ajax_calls-2415027-13.patch621 bytessam.spinoy@gmail.com
#12 views-refresh_multiple_ajax_calls-2415027-12.patch619 bytesKarlShea
#9 views-refresh_multiple_ajax_calls-2415027-9.patch641 bytesmaximpodorov
#5 views-refresh-multiple-ajax-calls-5.patch641 bytesdave.erwin
#4 views-refresh-multiple-ajax-calls-4.patch637 bytesdave.erwin
#1 view-refresh-multiple-ajax-calls.patch820 bytesn_vashenko
view-refresh-multiple-ajax-calls.patch5.82 KBn_vashenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

n_vashenko’s picture

n_vashenko CreditAttribution: n_vashenko commented
FileSize
view-refresh-multiple-ajax-calls.patch820 bytes
lklimek’s picture

lklimek CreditAttribution: lklimek at Software Inn commented
Version: 7.x-3.8 » 7.x-3.11
Status: Active » Needs review

I also have this issue, reproduced on clean drupal install.

Repro scenario:
1. install Drupal 7 + Views 3.11
2. create an ajax-enabled view 'test' and some content to display in this view
3. go to the view page and execute in JS console Drupal.attachBehaviors, for example: Drupal.attachBehaviors(jQuery('#header'))
4. inspect div containing your view (the one with class "view"): it now contains 2 jQuery event handlers attached to RefreshView event
5. repeat point 3 several times and notice that number of RefreshView handlers is increasing with every attachBehaviors() call

The patch #1 fixes the issue for me.

Status: Needs review » Needs work

The last submitted patch, 1: view-refresh-multiple-ajax-calls.patch, failed testing.

dave.erwin’s picture

dave.erwin CreditAttribution: dave.erwin commented
FileSize
views-refresh-multiple-ajax-calls-4.patch637 bytes

thanks for the patch, this issue was driving me crazy.
resubmitting patch for testing.

dave.erwin’s picture

dave.erwin CreditAttribution: dave.erwin commented
FileSize
views-refresh-multiple-ajax-calls-5.patch641 bytes

actually, I did some testing and was getting the error:
Uncaught TypeError: self.setInterval is not a function
when using the sharethis service, I changed
self = this;
to
var self = this;
to clear up the error

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea commented
Status: Needs work » Reviewed & tested by the community

Fixed my issue.

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea commented
KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea commented
Version: 7.x-3.11 » 7.x-3.x-dev

Sorry for the spam, forgot to update version

maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented
FileSize
views-refresh_multiple_ajax_calls-2415027-9.patch641 bytes

The patch is renamed to include the issue number.

dsutter’s picture

dsutter CreditAttribution: dsutter as a volunteer commented

RTBC+ patch #9

gdaw’s picture

gdaw CreditAttribution: gdaw as a volunteer commented

Confirmed RTBC+1 for patch #9

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea commented
FileSize
views-refresh_multiple_ajax_calls-2415027-12.patch619 bytes

Reroll

sam.spinoy@gmail.com’s picture

sam.spinoy@gmail.com CreditAttribution: sam.spinoy@gmail.com at Adapt commented
FileSize
views-refresh_multiple_ajax_calls-2415027-13.patch621 bytes

Reroll for latest release

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Issue tags: -, -#views
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3054023: Plan for Views 7.x-3.24 release

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.