Calendar was identified as a performance drag during a performance audit.

The website has lots of fields and Views
Saving Views is invoked calendar_views_templates(), which loads each field -> field_info_field.
After that is invoked calendar_views_template_construct(), which changes Views.
It needs about 4 seconds to execute all requests.

This section of code should be checked out.

CommentFileSizeAuthor
#2 calendar-skip_views_templates-2414845-2.patch1.61 KBmaximpodorov
profiler.png63.11 KBm.lebedev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m.lebedev’s picture

m.lebedev CreditAttribution: m.lebedev commented
Issue summary: View changes
maximpodorov’s picture

maximpodorov CreditAttribution: maximpodorov commented
Status: Active » Needs review
FileSize
calendar-skip_views_templates-2414845-2.patch1.61 KB

The patch adds new setting to omit views templates creation.

m.lebedev’s picture

m.lebedev CreditAttribution: m.lebedev commented

I think this is a good solution.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Title: Low performance. Needs optimization. » Performance for calendar_views_templates()
Status: Needs review » Reviewed & tested by the community
Issue tags: -optimization +Performance

Yes this sounds like a good solution. I don't use the templates. That function could use a bunch of clean-up too but that could be a different follow-up patch.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Reviewed & tested by the community » Closed (outdated)
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Closed (outdated) » Fixed

@maximpodorov actually I'll take over some of the D7 and help with D8 maintainership so this patch has been committed to the dev branch.

Also, thanks @Neslee Canil Pinto!

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented

@joelpittet +1, thanks for you help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.