The theme is great, I use it more and more now. Although I have spotted a couple minor display errors such as:

  • admin/config floating columns not floating due to having class 'clearfix' and that class having clear: both
  • Fieldsets not opening properly inside views configuration popup windows due to system class overrides
  • Tables having overflow: hidden and as such not showing the edit dropdown list
  • Edit dropdown list having wrongly positioned arrow

I've fixed these and it all works fine now. Been using this theme in two of my projects and haven't noticed any other errors in different areas that might show up.

CommentFileSizeAuthor
#1 tables_clearfix_dropdown_fixes-2413611.patch3.37 KBjzavrl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jzavrl’s picture

jzavrl CreditAttribution: jzavrl commented
Status: Active » Needs review
FileSize
tables_clearfix_dropdown_fixes-2413611.patch3.37 KB

Attached patch.

othermachines’s picture

othermachines CreditAttribution: othermachines commented

I'm not sure, but I wonder if unrelated styling issues - even small ones - should be split into separate posts to make testing a bit easier and minimize overlap with other patches. For instance, I think the clearing column issue may have been fixed here.

chiebert’s picture

chiebert CreditAttribution: chiebert commented

+1 for breaking this issue issue up into multiples - and perhaps some screenshots, too, please, while you're at it. As it stands:

  1. I've just updated to the latest 7.x-2.0-alpha3 release, with no patches applied, and confirm that the admin/config float issue is fixed as per #2420073: clearfix override breaking two-column layout at admin/config.
  2. I don't think I'm able to reproduce the non-opening fieldsets inside Views config modals/popups. They seem to be working for me with -alpha3.
  3. It would be good to know which tables have the overflow:hidden issue.
  4. Ditto for the 'edit dropdowns'.