Problem/Motivation

Action plugins are supposed to be re-usable. But Drupal\node\Form\DeleteMultiple has a hardcoded redirect back to admin/content. If you re-use that in a different view, you are redirect to the wrong view.

Proposed resolution

The confirm_form_route_name redirect should add a destination back to the current page.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 bulkform_add_destination-2413461-5-complete.patch2.19 KBgeertvd
#5 bulkform_add_destination-2413461-5-test.patch1.39 KBgeertvd
#1 bulkform_add_destination-2413461-1.patch821 bytesgeertvd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geertvd’s picture

geertvd CreditAttribution: geertvd commented
FileSize
bulkform_add_destination-2413461-1.patch821 bytes
geertvd’s picture

geertvd CreditAttribution: geertvd commented
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Reviewed & tested by the community

After testing manually, I can confirm this patch adds the destination properly.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Let's add a test.

geertvd’s picture

geertvd CreditAttribution: geertvd commented
FileSize
bulkform_add_destination-2413461-5-test.patch1.39 KB
bulkform_add_destination-2413461-5-complete.patch2.19 KB
geertvd’s picture

geertvd CreditAttribution: geertvd commented
Status: Needs work » Needs review

The last submitted patch, 5: bulkform_add_destination-2413461-5-test.patch, failed testing.

pjbaert’s picture

pjbaert
Primary language Dutch
CreditAttribution: pjbaert commented
Status: Needs review » Reviewed & tested by the community

@geertvd added the test

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs tests

Nice. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 27f69c2 and pushed to 8.0.x. Thanks!

  • alexpott committed 27f69c2 on 8.0.x 
    Issue #2413461 by geertvd: Views BulkForm should add destination to go...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.