ViewStorageTest::displayMethodTests() needs @todo love.

Problem/Motivation

Working on coding standards for the Views module here: #2385209: Clean-up views module test members - ensure property definition and use of camelCase naming convention

We encountered some commented-out code in Drupal\views\Tests\ViewStorageTest::displayMethodTests() with a @todo and no issue.

This is that issue.

The lines in question look like this, bemoaning the fact that View::generateDisplayId() is protected:

    // Tests Drupal\views\Entity\View::generateDisplayId().
    // @todo Sadly this method is not public so it cannot be tested.
    // $view = $this->controller->create(array());
    // $this->assertEqual($view->generateDisplayId('default'), 'default', 'The plugin ID for default is always default.');
    // $this->assertEqual($view->generateDisplayId('feed'), 'feed_1', 'The generated ID for the first instance of a plugin type should have an suffix of _1.');
    // $view->addDisplay('feed', 'feed title');
    // $this->assertEqual($view->generateDisplayId('feed'), 'feed_2', 'The generated ID for the first instance of a plugin type should have an suffix of _2.');

Proposed resolution

Use reflection to allow test access to generateDisplayId().

Remaining tasks

User interface changes

API changes

Beta phase evaluation