When you crop a image, the croped image replaces the old one, so, when you see the page for th first time, you will see the old image, as it is client side cached.

This patch solves the issue renaming the new croped image, so the url will be diferent and the browser will no cache it.

CommentFileSizeAuthor
#9 imagefield_crop-2412183-9-new_filename_strategy.patch6.24 KBmrinalini9
#7 imagefield_crop-2412183-7-new_filename_strategy.patch6.24 KBjascote
#6 interdiff-2412183-5-6.txt1.66 KBLes Lim
#6 imagefield_crop-2412183-6-new_filename_strategy.patch6.25 KBLes Lim
#5 imagefield_crop-save-unmanaged-to-avoid-cache-2412183-5.patch6.17 KBaltrugon
#4 imagefield_crop-2412183-4.patch6.26 KBLes Lim
#3 imagefield_crop-save-unmanaged-to-avoid-cache-2412183-3.patch2.22 KBjoe_carvajal
#2 imagefield_crop-save-unmanaged-to-avoid-cache-2412183-2.patch483 bytesboshtian
#1 imagefield_crop-2412183-1-original-image-displayed-first-time-1x-port.patch880 bytesakalam
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akalam’s picture

akalam CreditAttribution: akalam commented
Status: Active » Needs review
FileSize
imagefield_crop-2412183-1-original-image-displayed-first-time-1x-port.patch880 bytes
boshtian’s picture

boshtian CreditAttribution: boshtian commented
FileSize
imagefield_crop-save-unmanaged-to-avoid-cache-2412183-2.patch483 bytes

Confirming the solution, but the patch is not working on latest dev version of 1.x branch.

Adding a new patch with same solution, just different line numbers.

Please test and if it's ok you can add this to 1.x dev version.

joe_carvajal’s picture

joe_carvajal
He/him
Primary language Spanish
Location Seville (Spain)
CreditAttribution: joe_carvajal at La Drupalera by Emergya commented
FileSize
imagefield_crop-save-unmanaged-to-avoid-cache-2412183-3.patch2.22 KB

Hi!

I had the same problem, but in my case I had two image field for the content type, one with the cropped image and other with the full image.
When you upload the same image twice (first one to crop and another one for preserve the full image), the browser caches the full image and won't load the cropped image properly until refresh the page.

I added a timestamp in the filename before save, just to avoid browser to cache the exact image.
I create the patch using the stable version (1.1) because it's the version we used in the project. Should I reroll it to the dev version?

Thank you for the patch, guys!

Edit: the "trailing spaces" were removed by my IDE, sorry about it :S Just noticed it after the file upload.

Les Lim’s picture

Les Lim
he/they
Primary language English
CreditAttribution: Les Lim at TEN7 commented
Title: Original image displayed when the node is viewed for the first time. (1.x port) » Replacement crops are not showing because of external file caching
Priority: Minor » Normal
FileSize
imagefield_crop-2412183-4.patch6.26 KB

Re-titling for clarity.

We had the same problem, but each of the above solutions ended up creating new, duplicate crop derivatives every time the parent entity form was saved, even if the crop settings hadn't been touched.

We also determined that we needed the filename of the cropped image to change in order to bypass external caching like CDN, Varnish, or browser-based cache. This patch alters the crop filename by appending the scale/crop parameters used to generate the crop. This should eliminate the possibility of many duplicates of the exact same crop. Meanwhile, the original image file is saved with its original filename.

The patch also prevents the crop from being regenerated if the crop settings have not actually changed.

altrugon’s picture

altrugon CreditAttribution: altrugon at Affinity Bridge commented
FileSize
imagefield_crop-save-unmanaged-to-avoid-cache-2412183-5.patch6.17 KB

The solution proposed by Les Lim #4 worked for me although I wasn't able to apply the patch and I had to do it manually.

I'm attaching my patch against 7.x-1.x (commit 69343ad0d548c7cbc98db2a2078d3c4e6fb987c8).

Les Lim’s picture

Les Lim
he/they
Primary language English
CreditAttribution: Les Lim at TEN7 commented
FileSize
imagefield_crop-2412183-6-new_filename_strategy.patch6.25 KB
interdiff-2412183-5-6.txt1.66 KB

This strategy is still mostly working for us after a couple months, except for one thing - trying to upload a file when the same filename already exists in the destination causes a PDOException. Drupal core deals with this by appending a counter to the filename to ensure unique filenames, but we forgot to do that here.

Here's a new patch off of 7.x-1.x-dev that runs the destination filepaths for both the original and derivative images through `file_destination()`.

jascote’s picture

jascote CreditAttribution: jascote commented
FileSize
imagefield_crop-2412183-7-new_filename_strategy.patch6.24 KB

The patch in #6 causes an image file rename for the cropped image that's different from the value in the file_managed table. This causes the cropped image to not be used. Changing the call to the _imagefield_crop_resize function to use FILE_EXISTS_REPLACE instead of FILE_EXISTS_RENAME fixes this.

Here's a patch that includes that update.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Status: Needs review » Needs work

Looks like this patch needs a re-roll against the latest -dev.

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
imagefield_crop-2412183-9-new_filename_strategy.patch6.24 KB

Rerolled patch #7 for 7.x-1.x branch, please review it.