In order to save space, oa_toolbar will truncate the list of sub-Spaces, but it doesn't currently give an indication that the list was truncated nor a way to view the remaining Subspaces. This patch will add a "More subspaces..." link which takes the user to a page with all the sub-Spaces in a given Space.

Currently, oa_toolbar doesn't truncate the list of Sections, however, this potentially has the same problem of getting too long that the other lists have, so it should be truncated too. This patch truncates the Section list and provides a similar "More sections..." link when it does.

This depends on this patch to oa_core, which actually adds the pages that these more links point to:

#2411693: Add "All sections" and "All subspaces" views pages

CommentFileSizeAuthor
#5 oa_toolbar-more-sections-subspaces-2411069-5.patch1.84 KBdsnopek
#4 oa_toolbar-more-sections-subspaces-2411069-4.patch1.84 KBdsnopek
#2 oa_toolbar-subspaces-truncate-2410477-2.patch1.84 KBdsnopek
#1 oa_toolbar-more-sections-subspaces-2411069-1.patch1.12 KBdsnopek
#1 Selection_006.png14.83 KBdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
Selection_006.png14.83 KB
oa_toolbar-more-sections-subspaces-2411069-1.patch1.12 KB

Oops! Forgot to attach the patch. :-)

Also, here is a screenshot of what this looks like:

To make the screenshot, I temporarily changed it to truncate after 1 item (rather than the normal 15), so normally you'd see a lot more sections here before the "More sections..." link appears. But this demonstrates more or less what it looks like!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
oa_toolbar-subspaces-truncate-2410477-2.patch1.84 KB

Needs to be on the 'sibling_list' as well! That is where the "Subspaces" come from when you are in a sub-Space and click the dropdown by the parent. Here is an updated patch!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Issue summary: View changes
Related issues: +#2411693: Add "All sections" and "All subspaces" views pages

Per Mike Potter, I'm moving the dependent PR from GitHub to an issue on D.o: #2411693: Add "All sections" and "All subspaces" views pages

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
oa_toolbar-more-sections-subspaces-2411069-4.patch1.84 KB

Blergh! Uploaded the wrong patch. This one should be right.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
oa_toolbar-more-sections-subspaces-2411069-5.patch1.84 KB

Ok, hopefully, this is the last patch on this issue. I linked to the wrong Space in the 'siblings_list' (to the current Space, rather than parent). New patch is attached!

hefox’s picture

hefox CreditAttribution: hefox commented

The patches look good, other then trying to find if there's a standard for more links, but couldn't find any more links in openatrium which makes me wander if this is the more link pattern want to introduce. Not just text, but whether they should link to view pages or panel pages displaying views.

mpotter’s picture

mpotter CreditAttribution: mpotter commented
Status: Needs review » Closed (outdated)

This is outdated due to the theme changes in v2.60