Please see this post I've just added in the Menu Attributes issue queue: https://www.drupal.org/node/2411003

Menu Views has a higher weight, so the form_alter function is overwriting the value of $form['description']['#access'] that's set by Menu Attributes. I'm not sure if this can be solved simply by Menu Attributes moving to a higher weight, or if that may cause some problems for Menu Views.

Menu Attributes is attempting to stop the Description field from rendering, store the value in the Menu Attributes title field, and save the value back to the hidden Description field. Probably the best approach would be to review each other's form_alter code to make sure you're both getting the values you'd expect.

Thanks for looking into this.

CommentFileSizeAuthor
#4 description_field-2411009-4.patch1.54 KBmarkhalliwell
#3 menu_views-menu_attributes_description-2411009-3.patch983 bytesron_s
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Postponed (maintainer needs more info)

You've created other patches, would you mind doing the same for this please. I don't have time to "look into it".

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Status: Postponed (maintainer needs more info) » Active

Sure, let me look at it. I had some ideas before, but didn't want to assume in case you had plans of how the module might change in the future.

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Version: 7.x-2.2 » 7.x-2.x-dev
Status: Active » Needs review
FileSize
menu_views-menu_attributes_description-2411009-3.patch983 bytes

Ok, I think this should work... essentially ignoring the show/hide of the description field if the Menu Attributes module is present. By doing so, Menu Attributes will have default control.

When Menu Attributes and Menu Views are both enabled, the description field is not displayed (as expected). If Menu Attributes is disabled, the description field is shown again.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
FileSize
description_field-2411009-4.patch1.54 KB

Looks good. I moved the module_exists check out of the foreach loop though. I'll commit once you RTBC.

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Status: Needs review » Reviewed & tested by the community

Good point, I should have done that. I've tested and looks good.

  • markcarver committed cc710c9 on authored by ron_s 
    Issue #2411009 by ron_s, markcarver: Description field conflict with...
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.