Strict warning message when updating reservation-status [#2410679]

Strict warning: Only variables should be passed by reference in restaurant_reservation_send_update_status_mail() (line 189 of /profiles/restaurant/modules/restaurant/restaurant_reservation/restaurant_reservation.module).

This message is shown after saving / updating the Reservation status on both reservation-admin-list and reservation-edit-form.

Comments

Comment #1

shadcn CreditAttribution: shadcn commented 12 February 2015 at 12:38

Hi. Can you please file an issue on Github here: https://github.com/drupalrestaurant/restaurant/issues. We are moving support and bug tracking to Github.

Comment #2

marcrobinsone CreditAttribution: marcrobinsone commented 12 February 2015 at 17:10

Roger that. Thanks for the head's up. I'll file future tickets there.

Comment #3

HyperD CreditAttribution: HyperD commented 28 December 2015 at 17:06

I changed in this way

280 -    //$params['body'] .= drupal_render(entity_view('reservation', array($reservation), 'email'));
281 +      $just_a_variable = entity_view('reservation', array($reservation), 'email');
282 +      $params['body'] .= drupal_render($just_a_variable);