Problem/Motivation

No text is displayed after "Missing translations:" on the Available translation updates report page.

Steps to reproduce

1. Install drupal 8. Make sure automatic updates are switched off.
2. Enable Language module.
3. Enable Interface translation.
4. Add a language on admin/config/regional/language
5. Enable the Update manager module.
6. Go to admin/reports/translations, the status of the added language is "Missing translations for one project
Drupal core (8.0.0-beta4). File not found at http://ftp.drupal.org/files/translations/8.x/drupal/drupal-8.0.0-beta4.h... nor at translations://drupal-8.0.0-beta4.hu.po" or similar.
7. Now click "Check manually".
Result: The status changes to: "Updates for: Drupal core
Drupal core (2015-01-19)
Missing translations for:" and is followed by nothing.

Proposed resolution

Change order of "Missing translations for:" and the list of modules.

CommentFileSizeAuthor
#48 2410315-nr-bot.txt145 bytesneeds-review-queue-bot
#43 lang_2.png100.66 KBlomale@bluewin.ch
#43 lang_1.png104.92 KBlomale@bluewin.ch
#33 Language_added.JPG377.4 KBTruptti
#33 No_error_displayed.JPG87.39 KBTruptti
#33 auto_update_switched_off.JPG126.41 KBTruptti
#32 on_available-2410315-32.patch4.18 KBmpdonadio
#26 on-available-translation-updates-report-2410315-26.patch4.17 KBharipalrao
#22 on_available-2410315-22.patch4.25 KBNitesh Sethia
#19 empty-missing-translations-2410315-19.diff3.94 KBbalagan
#16 empty-missing-translations-2410315-16.diff4.29 KBbalagan
#13 empty-missing-translations-2410315-13.diff1.46 KBbalagan
#8 empty-missing-translations-2410315-8.diff696 bytesbalagan
#4 empty-missing-translations-2410315-4.diff658 bytesbalagan
#1 missing-translations.jpg139.86 KBbalagan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

balagan’s picture

balagan CreditAttribution: balagan commented
Issue summary: View changes
FileSize
missing-translations.jpg139.86 KB
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +D8MI, +language-ui
balagan’s picture

balagan CreditAttribution: balagan commented
Issue summary: View changes
balagan’s picture

balagan CreditAttribution: balagan commented
FileSize
empty-missing-translations-2410315-4.diff658 bytes

The template_preprocess_locale_translation_update_info function in the core\modules\locale\locale.pages.inc file is responsible for this.
On line 99 $details['missing_updates_list']['#prefix'] = t('Missing translations for:'); happens even if the '#items' in the 'missing_updates_list' array is empty. That is set from the $releases variable, so I check if that is !empty().

balagan’s picture

balagan CreditAttribution: balagan commented
Status: Active » Needs review
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +Needs tests

Is there a test that we can expand to check for this? That would be great!

balagan’s picture

balagan CreditAttribution: balagan commented

Or maybe just change line 78 to !empty() instead of isset()?

balagan’s picture

balagan CreditAttribution: balagan commented
FileSize
empty-missing-translations-2410315-8.diff696 bytes

I think using !empty() is a better solution. That whole code has no point to run, if $variables['not_found'] is empty.

The last submitted patch, 4: empty-missing-translations-2410315-4.diff, failed testing.

isntall queued 4: empty-missing-translations-2410315-4.diff for re-testing.

balagan’s picture

balagan CreditAttribution: balagan commented

Actually "Missing translations for" is a bit misleading. Seeing the code it seems it displays the list of the missing updates (files not found). First I thought it would be listing projects with downloadeble translations.
Should we change it to "Missing updates for:" instead? I think that describes more properly what it would show.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Makes sense to me.

balagan’s picture

balagan CreditAttribution: balagan commented
FileSize
empty-missing-translations-2410315-13.diff1.46 KB

I have changed "Missing translations for" to "Missing updates for:"

Status: Needs review » Needs work

The last submitted patch, 13: empty-missing-translations-2410315-13.diff, failed testing.

balagan’s picture

balagan CreditAttribution: balagan commented
Assigned: Unassigned » balagan
balagan’s picture

balagan CreditAttribution: balagan commented
Assigned: balagan » Unassigned
FileSize
empty-missing-translations-2410315-16.diff4.29 KB

Updated failing tests.

balagan’s picture

balagan CreditAttribution: balagan commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 16: empty-missing-translations-2410315-16.diff, failed testing.

balagan’s picture

balagan CreditAttribution: balagan commented
FileSize
empty-missing-translations-2410315-19.diff3.94 KB

Forgot to git diff after fixing this.

balagan’s picture

balagan CreditAttribution: balagan commented
Status: Needs work » Needs review
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

This appears to have some test coverage, but could potentially be expanded. Patch no longer applies though.

Nitesh Sethia’s picture

Nitesh Sethia CreditAttribution: Nitesh Sethia as a volunteer commented
Status: Needs work » Needs review
FileSize
on_available-2410315-22.patch4.25 KB

Rerolled the patch as per the latest D8 release.

Status: Needs review » Needs work

The last submitted patch, 22: on_available-2410315-22.patch, failed testing.

Status: Needs work » Needs review

rpayanm queued 22: on_available-2410315-22.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 22: on_available-2410315-22.patch, failed testing.

haripalrao’s picture

haripalrao CreditAttribution: haripalrao commented
FileSize
on-available-translation-updates-report-2410315-26.patch4.17 KB

Rerolled

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
CreditAttribution: vaibhavjain as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs reroll

Updated status, and removed tag.

Status: Needs review » Needs work

The last submitted patch, 26: on-available-translation-updates-report-2410315-26.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: +Needs reroll

Looks like that did not last long unfortunately :/ Sorry nobody had time to do a quick review in the meantime :/

Status: Needs work » Needs review

haripalrao queued 26: on-available-translation-updates-report-2410315-26.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 26: on-available-translation-updates-report-2410315-26.patch, failed testing.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
on_available-2410315-32.patch4.18 KB 
$ git checkout 9dfa950c9cb9bcc87e81d32777e4ab04d750f127
$ git rebase 8.0.x
First, rewinding head to replay your work on top of it...
Applying: on-available-translation-updates-report-2410315-26.patch
Using index info to reconstruct a base tree...
M	core/modules/locale/locale.pages.inc
M	core/modules/locale/src/Tests/LocaleUpdateInterfaceTest.php
M	core/modules/locale/src/Tests/LocaleUpdateTest.php
Falling back to patching base and 3-way merge...
Auto-merging core/modules/locale/src/Tests/LocaleUpdateTest.php
Auto-merging core/modules/locale/src/Tests/LocaleUpdateInterfaceTest.php
CONFLICT (content): Merge conflict in core/modules/locale/src/Tests/LocaleUpdateInterfaceTest.php
Auto-merging core/modules/locale/locale.pages.inc
Failed to merge in the changes.

specifically

<<<<<<< HEAD
    $this->assertText(t('Missing translations for one project'), 'No translations found');
    $this->assertText(SafeMarkup::format('@module (@version). !info', array('@module' => 'Locale test translate', '@version' => '1.3-dev', '!info' => t('No translation files are provided for development releases.'))), 'Release details');
=======
    $this->assertText(t('Missing updates for one project'), 'No translations found');
    $this->assertText(String::format('@module (@version). !info', array('@module' => 'Locale test translate', '@version' => '1.3-dev', '!info' => t('No translation files are provided for development releases.'))), 'Release details');
>>>>>>> on-available-translation-updates-report-2410315-26.patch

Pretty sure this is the correct merge, and LocaleUpdateInterfaceTest passes locally now.

Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
FileSize
auto_update_switched_off.JPG126.41 KB
No_error_displayed.JPG87.39 KB
Language_added.JPG377.4 KB

Tried verifying the issue as per the steps mentioned, but the error is not displayed on '/admin/reports/translations' page (made sure that auto update is switched off).Could not reproduce the error.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lpalgarvio’s picture

lpalgarvio CreditAttribution: lpalgarvio as a volunteer commented
Related issues: +#750000: Failed to fetch information when behind a proxy

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

lomale@bluewin.ch’s picture

lomale@bluewin.ch CreditAttribution: lomale@bluewin.ch as a volunteer and commented
FileSize
lang_1.png104.92 KB
lang_2.png100.66 KB

Hi i come back on this.

I have "Missing translations for 13 projects" for language English.

I found out that somewhere the path for eng i.e.

https://ftp.drupal.org/files/translations/all/address/address-8.x-1.9.en.po

has been changed to
address-8.x-1.9.en-gb.po 03-Nov-2020 17:47 787

See pictures 1+2

I'm on
Drupal-Version 8.9.13
PHP 7.4.16

you can we fix that??

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2410315-nr-bot.txt145 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.