Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Current module documentaion described in API.txt file http://cgit.drupalcode.org/aes/tree/API.txt
Proposed resolution
Rewrite module documentation to aes.api.php accordingly to recomendation https://www.drupal.org/update/modules/6/7#api_php
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-2409773-5-7.txt | 12.68 KB | andriyun |
#7 | rewrite_documentation-2409773-7.patch | 24.03 KB | andriyun |
Comments
Comment #1
andriyun CreditAttribution: andriyun commentedComment #2
dpovshed CreditAttribution: dpovshed commentedgreat, please go for it!
Comment #3
dpovshed CreditAttribution: dpovshed commentedComment #4
andriyun CreditAttribution: andriyun commentedComment #5
andriyun CreditAttribution: andriyun commentedThere is patch provide new doc file aes.api.php insted old API.txt
and add docblock to aes.module for functions
Comment #6
podarokFASLE
boolean in Drupal should be UPPERCASE
usage
usage
for the operation
80 symbols per line. please
Remove trailing comment after $uid, please
FALSE otherwise
80 symbols per line. please
FALSE otherwise
Loads
Inits
Validates
Submits
fullstop please
fullstop please
Remove trailing comment
wrap to 80 symbols per line. please
FALSE otherwise
80 symbols per line, please
@return string
80 symbols per line
@return bool
TRUE and FALSE everywhere
FALSE otherwise
Explain it, FALSE = something, TRUE otherwise
Comment #7
andriyun CreditAttribution: andriyun commented@podarok Thanks a lot for review.
Review fixes.
Comment #8
andriyun CreditAttribution: andriyun commentedComment #9
dpovshed CreditAttribution: dpovshed commented'Your custom code'
- $decrypt is not an user ID;
- again, false => FALSE
Comment #11
dpovshed CreditAttribution: dpovshed commentedCommitted, slightly tuned after commit. Thanks @andriyun & @podarok!