Increase discoverability of view modes

I have implemented the changes in manage display of all entities.
please find the patch.

Thanks,
Mayur Jadhav.

The same link and text is displayed if you go to the 'Manage form display' tab, which is not good :) Over there we need to change the link and the text to "Manage form modes".

I have created a new patch with different display context modes.

+++ b/core/modules/field_ui/src/Form/EntityDisplayFormBase.php
@@ -237,10 +238,20 @@ public function form(array $form, FormStateInterface $form_state) {
+          '#title' => $this->t('Use custom display settings for the following ' . $this->displayContext . ' modes'),
...
+          '#markup' => \Drupal::l(t('Manage ' . $this->displayContext . ' modes'), $url),

You can not do string concatenation like this in the t() function, any dynamic string has to be sent as a parameter, as explained in https://api.drupal.org/api/drupal/core!includes!bootstrap.inc/function/t/8 and https://api.drupal.org/api/drupal/core!lib!Drupal!Component!Utility!Stri....

Also, instead of trying to do everything in the base class, it would be cleaner if you provide the element like this:

$form['modes']['display_modes_link'] = $this->getDisplayModesLink();

provide an abstract method getDisplayModesLink() in the base class and implement it in each extending class with the proper titles and urls.

This also needs a sign-off from someone in the usability team to decide if it's a good thing to do or not. The issue is already tagged so we just need to wait :)

As I'm new in drupal 8 sorry for my poor coding.
I'll provide a proper patch with drupal 8 coding standards.

This ticket seems related.

Patch attached refactors #4 and implements the suggestions from #8.

I guess we know already the routes names, why not use them explicitly ?
I found that trying to get a way to pass the tests.

   protected function getDisplayModesLink() {
-    // Get the route name.
-    $url_object = \Drupal::service('path.validator')->getUrlIfValid('admin/structure/display-modes/form');
-    $route_name = $url_object->getRouteName();
 
     return [
       '#type' => 'link',
       '#title' => t('Manage form modes'),
-      '#url' => Url::fromRoute($route_name),
+      '#url' => Url::fromRoute('entity.entity_form_mode.collection'),

and

protected function getDisplayModesLink() {
-    // Get the route name.
-    $url_object = \Drupal::service('path.validator')->getUrlIfValid('admin/structure/display-modes/view');
-    $route_name = $url_object->getRouteName();
+  protected function getDisplayModesLink() {;
 
     return [
       '#type' => 'link',
       '#title' => t('Manage view modes'),
-      '#url' => Url::fromRoute($route_name),
+      '#url' => Url::fromRoute('entity.entity_view_mode.collection'),

The patch looks OK to me. I've tested it and it works as expected.
I just attached a patch to remove some unwanted line breaks and rephrased the abstracted method.

+++ b/core/modules/field_ui/src/Form/EntityDisplayFormBase.php
@@ -205,10 +205,12 @@ public function form(array $form, FormStateInterface $form_state) {
+        // Provide link to manage viewmodes.

Should probably be something like 'Provide link to manage display modes.'

Update with suggestion at #24

Thanks,
on the Manage display page in Custom display settings section, there is now a link Manage view modes, and on the Manage form display there is Manage form modes.
Both provide simply links for users who want to use additional form or view modes, and first checked whether there already is a suitable one that only needs enabling. This is also useful for users who were not aware that they can create additional modes.

Screenshots:

Looks good to me, I had trouble finding that page just last week.

PHPCS: core/modules/field_ui/src/Form/EntityDisplayFormBase.php passed

FILE: ...8.x/core/modules/field_ui/src/Form/EntityFormDisplayEditForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 25ms; Memory: 4Mb


FILE: ...8.x/core/modules/field_ui/src/Form/EntityViewDisplayEditForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Fixed these on commit.