Suggested commit message

git commit -m 'Issue #2409579 by katzilla, k4v: Allow to enter the machine name in the module filter'

Problem/Motivation

If you search on admin/modules you'll just find the title of the module, not the machine name. This is really annoying if you know the machine name already.

Proposed resolution

Expand the test search.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Feature request
Issue priority Not critical because the module filter works without this feature
Unfrozen changes Unfrozen because it only changes markup
Prioritized changes Prioritized change because it is a usability and user experience improvement.
Disruption Not disruptive
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

katzilla’s picture

here is the patch.

katzilla’s picture

Status: Active » Needs review
k4v’s picture

.

k4v’s picture

.

dawehner’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Seems legit

k4v’s picture

Issue summary: View changes
k4v’s picture

Issue summary: View changes
k4v’s picture

Issue summary: View changes
alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.

k4v’s picture

@alexpott: katzilla and me were working on this together on the sprint weekend.

k4v’s picture

.

k4v’s picture

Issue summary: View changes
k4v’s picture

Issue summary: View changes
k4v’s picture

Issue summary: View changes
k4v’s picture

Status: Needs work » Needs review
k4v’s picture

Status: Needs review » Reviewed & tested by the community
k4v’s picture

Issue summary: View changes
tstoeckler’s picture

Issue summary: View changes
tstoeckler’s picture

I just remembered #381994: Machine-name fields are always in Latin characters, and should therefore always be LTR and realized that the machine name really should have a dir attribute. So since we're changing that markup anyway here, I went ahead and added it. Hope it's okay to leave this at RTBC.

The interdiff is in form of a picture: :-)
The interdiff as the output of git diff --color-words.

dawehner’s picture

Good catch!

  • alexpott committed 58179dc on 8.0.x
    Issue #2409579 by tstoeckler, katzilla, k4v: Allow to enter the machine...
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 58179dc and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.