The load callback for page_manager_handlers (introduced in #1371436: Panels: page_manager_handlers variant weights are not exported and imported) always resets the 'export_type' property to EXPORT_IN_DATABASE.

I'm sure its reasons are valid, but I'm also pretty sure it should not do that when the status is already overridden. Now you don't get to see which pages are properly exported and which are still changed in the database.

(Correction: a human gets to see it, because the UI label still says "Overridden". But my code, which looks at 'export_type', does not see it.)

The first 2 line deletions in the patch are just unrelated unused variables (yay PHPStorm)

CommentFileSizeAuthor
page_manager-export_task_handler-overridden.patch1.14 KBroderik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
CreditAttribution: roderik commented
Issue summary: View changes
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented

The 3 year old patch to page_manager.module applied cleanly to the latest ctools 7.x-1.x-dev and if still applicable needs to be reviewed and tested.

Checking patch page_manager/page_manager.module...
Hunk #1 succeeded at 741 (offset 33 lines).
Hunk #2 succeeded at 752 (offset 33 lines).
Applied patch page_manager/page_manager.module cleanly.