The TFA basic help page plugin #2326253: Provide help page plugin is implemented without form input fields so the TFA basic trusted browser plugin doesn't make any sense on the page.

TFA should support some way of a plugin disallowing a login plugin from applying to the step.

CommentFileSizeAuthor
#3 2409455-tfa-no-login-3.patch710 bytescoltrane
#2 2409455-tfa-no-login-2.patch711 bytescoltrane
#1 2409455-tfa-no-login.patch708 bytescoltrane
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
Status: Active » Needs review
FileSize
2409455-tfa-no-login.patch708 bytes

Patch allows a TFA plugin form to return a form value of 'tfa_no_login' to disallow login plugins from applying to the form.

coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
FileSize
2409455-tfa-no-login-2.patch711 bytes

Changed to '#tfa_no_login' and fixed conditional logic.

coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
FileSize
2409455-tfa-no-login-3.patch710 bytes

And removing double negative.

coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
Status: Needs review » Fixed

  • coltrane committed 6d2d383 on 7.x-2.x 
    Issue #2409455 by coltrane: Allow a plugin to deny login plugins...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.