Hello,

I use Drupalchat with the Nodejs polling methode and I have remarqued an issue.
Each message are written in the database which is useless in nodejs and can be a performance issues.

I have made a quick diff patch to resolve this.

CommentFileSizeAuthor
#4 2408607-drupalchat_nodejs_no_log-4.patch788 bytesSocialNicheGuru
drupalchat_nodejs_no_log.patch17.69 KBttournie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented
Status: Active » Needs review
SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

if you did not write the message to the db, then how would nodejs know which message to send?

In function drupalchat_channel_add(),
the json data is defined in this way around line 695

'data' => drupal_json_encode($message),
SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

Could the original patch get cleaned up to just include the needed portions?

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented
Version: 7.x-1.4 » 7.x-2.5
FileSize
2408607-drupalchat_nodejs_no_log-4.patch788 bytes

Re-roll against 2.5 with just relevant portion

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

Do we need to write users to the database if we do not need to write messages to the database with nodejs?

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Version: 7.x-2.5 » 7.x-2.x-dev